Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "Chain" arrow type #10

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Conversation

ZizzyZizzy
Copy link
Contributor

When the "Chain" arrow hits a living entity, reduced damage vanilla arrows shoot out from the hit entity directly towards any other nearby living entities.

I was play-testing on 1.15.2 PaperSpigot. No errors were encountered with any of the arrow types.

Copy link
Owner

@2008Choco 2008Choco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to this change at all. In fact, this is a request I've seen come up a number of times. Aside from the two notes I've mentioned, I want to also request that you try to abide by whitespace standards as in the rest of the project. i.e. if (shooter == hitEntity) { in place of if(shooter == hitEntity){, as well as new lines to break up blocks of code where it makes the most amount of sense (generally after a closing statement).

src/main/java/wtf/choco/arrows/AlchemicalArrows.java Outdated Show resolved Hide resolved
Server owner controlled Chain damage & search radius.
Formatting changes to match existing style.
Slimeball instead of Firework for Chain arrow recipe.
@ZizzyZizzy
Copy link
Contributor Author

Changes pushed in fc70a66

@2008Choco
Copy link
Owner

This all looks well and good. A few tweaks I'll make after the fact (mainly regarding whitespace), but I think this is ready to go. Thank you 😄 I appreciate the contribution. Your PR will be attributed in the next changelog.

@2008Choco 2008Choco merged commit 61e02cc into 2008Choco:master Feb 26, 2020
@ZizzyZizzy
Copy link
Contributor Author

Awesome, thanks! It was fun. First one for a new developer here.

@ZizzyZizzy ZizzyZizzy deleted the upstream branch February 26, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants