-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new "Chain" arrow type #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to this change at all. In fact, this is a request I've seen come up a number of times. Aside from the two notes I've mentioned, I want to also request that you try to abide by whitespace standards as in the rest of the project. i.e. if (shooter == hitEntity) {
in place of if(shooter == hitEntity){
, as well as new lines to break up blocks of code where it makes the most amount of sense (generally after a closing statement).
Server owner controlled Chain damage & search radius. Formatting changes to match existing style. Slimeball instead of Firework for Chain arrow recipe.
Changes pushed in fc70a66 |
This all looks well and good. A few tweaks I'll make after the fact (mainly regarding whitespace), but I think this is ready to go. Thank you 😄 I appreciate the contribution. Your PR will be attributed in the next changelog. |
Awesome, thanks! It was fun. First one for a new developer here. |
When the "Chain" arrow hits a living entity, reduced damage vanilla arrows shoot out from the hit entity directly towards any other nearby living entities.
I was play-testing on 1.15.2 PaperSpigot. No errors were encountered with any of the arrow types.