Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button in headline menu to open property editor #195

Merged
merged 4 commits into from
Jan 7, 2020

Conversation

schoettl
Copy link
Collaborator

@schoettl schoettl commented Jan 1, 2020

This wants to close #170

But I don't understand the framework good enough to implement this in a proper way.

There must be a better way as duplicating the case 'property-list-editor' in OrgFile/index.js.

@munen munen force-pushed the feat/edit-properties-button branch from d9e833a to 46db2d1 Compare January 7, 2020 14:27
@munen
Copy link
Collaborator

munen commented Jan 7, 2020

@schoettl How about d9e833a ?

As far as I can tell, there's always a selectedHeader when calling the PropertyListEditorModal. It doesn't matter if we call it from the HeaderActionBar (you're new implementation) or by clicking on existing properties.

Unfortunately we don't have tests for this feature, yet, but it works for my manual tests(;

In any case: Very nice addition 🙏

If you're happy with my change, let's remove the WIP, and pull the feature in!

@schoettl
Copy link
Collaborator Author

schoettl commented Jan 7, 2020

Thanks, that looks good. I just fixed a variable name.

@schoettl schoettl changed the title [WIP] Button in headline menu to open property editor Button in headline menu to open property editor Jan 7, 2020
@munen
Copy link
Collaborator

munen commented Jan 7, 2020

Nice, let’s merge the feature in, then!

@munen munen merged commit d35f8c6 into 200ok-ch:master Jan 7, 2020
@schoettl schoettl deleted the feat/edit-properties-button branch January 7, 2020 17:30
@munen
Copy link
Collaborator

munen commented Jan 10, 2020

A little late, but I did update the changelog with attribution: 8ef4e6c

Thank you, again 🙏

@schoettl
Copy link
Collaborator Author

No problem and thank you for getting it to work ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants