Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auto-capitalization for search #914

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

neildavidforrest
Copy link
Contributor

This disables auto-capitalization for the search fields on Android Chrome as described here: #913

This is tested only on Chrome for Android only. I also checked Firefox for Android, this works fine (no auto-capitalization) with or without this change.

I'm unable to test with iOS, so that should be checked carefully for regressions.

@schoettl
Copy link
Collaborator

schoettl commented Dec 6, 2022

I'm not sure about autoComplete off. Have you tested if the suggestions from the dynamic datalist still work? E.g. if I type : or T, the completion list opens with matching tags or TODO keywords. This at least works on master in Firefox.

@neildavidforrest
Copy link
Contributor Author

I'm also not sure about it... but I can say that in my tests autoCapitalize="none" is not sufficient to disable the auto shift key by itself.

I can confirm that the auto complete still works correctly on Chrome mobile, and Firefox desktop after this change.

image

On Firefox mobile the auto complete does not work before or after, so no change there...

I didn't find any authoritative source about this, but there is some discussion here: https://stackoverflow.com/questions/13284323/how-can-i-stop-auto-capitalization-in-a-html-text-input-field-on-an-android-sams

@schoettl
Copy link
Collaborator

schoettl commented Dec 6, 2022

Oh good, if it still works, I'm fine :) Thanks for testing and this PR!

@munen
Copy link
Collaborator

munen commented Jan 4, 2023

Hi @neildavidforrest

Thank you for this PR! My apologies the the late answer 🙏 🙇

Thank you for the thorough testing on Android. I have tested on FF and Chromium on Linux, there are no regressions. Furthermore, iOS had the same undesirable auto-capitalization as you described it on Android. Your PR fixes this, as well 👍

I have fixed the test and updated the changelog. This is ready to go.

Thank you for yet another great productivity contribution 🙏 💯 🚀

@munen
Copy link
Collaborator

munen commented Jan 4, 2023

Thank you @schoettl for getting involved and double checking about the autoComplete flag. I was curious, too, and your question saved me time on the review 🙏 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants