Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove konacha javascript tests #1645

Merged
merged 1 commit into from Dec 1, 2016
Merged

Remove konacha javascript tests #1645

merged 1 commit into from Dec 1, 2016

Conversation

andrew
Copy link
Member

@andrew andrew commented Dec 1, 2016

Konacha added a lot of dependencies and overhead just to test the emoji js and it's not been updated to work with rails 5 either so I'm taking a 馃敧 to it and removing it for now, will make things simpler for new users and less of a headache for upgrading to rails 5.

@adamyeats
Copy link
Contributor

Very good shout! 馃憤

@andrew andrew merged commit 51acf28 into master Dec 1, 2016
@andrew andrew deleted the remove-konacha branch December 1, 2016 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants