Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove konacha javascript tests #1645

Merged
merged 1 commit into from Dec 1, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Expand Up @@ -7,7 +7,7 @@ env:
- DB=postgresql

script:
- RAILS_ENV=test POLTERGEIST=true bundle exec rake --trace db:migrate spec konacha:run && bundle exec codeclimate-test-reporter
- RAILS_ENV=test POLTERGEIST=true bundle exec rake --trace db:migrate spec && bundle exec codeclimate-test-reporter

before_script:
- psql -c 'create database tfpullrequests_test' -U postgres
Expand Down
7 changes: 0 additions & 7 deletions Gemfile
Expand Up @@ -60,13 +60,6 @@ group :development, :test, :cucumber do
gem 'webmock', require: false
gem 'timecop'
gem 'christmas_tree_formatter'

# Javascript
gem 'konacha'
gem 'chai-jquery-rails'
gem 'sinon-chai-rails'
gem 'sinon-rails'
gem 'ejs'
end

group :production do
Expand Down
28 changes: 3 additions & 25 deletions Gemfile.lock
Expand Up @@ -50,16 +50,13 @@ GEM
bugsnag (5.0.1)
builder (3.2.2)
callsite (0.0.11)
capybara (2.10.1)
capybara (2.10.2)
addressable
mime-types (>= 1.16)
nokogiri (>= 1.3.3)
rack (>= 1.0.0)
rack-test (>= 0.5.4)
xpath (~> 2.0)
chai-jquery-rails (2.0.0)
railties (>= 3.1)
sprockets
christmas_tree_formatter (0.1.0)
rspec-core (~> 3.0)
cliver (0.3.2)
Expand All @@ -72,7 +69,6 @@ GEM
coffee-script-source
execjs
coffee-script-source (1.11.1)
colorize (0.8.1)
concurrent-ruby (1.0.2)
crack (0.4.3)
safe_yaml (~> 1.0.0)
Expand All @@ -92,7 +88,6 @@ GEM
json
thread
thread_safe
ejs (1.1.1)
equalizer (0.0.10)
erubis (2.7.0)
ethon (0.9.1)
Expand Down Expand Up @@ -150,14 +145,6 @@ GEM
kaminari (0.17.0)
actionpack (>= 3.0.0)
activesupport (>= 3.0.0)
konacha (4.0.0)
actionpack (>= 4.1, < 5)
capybara
colorize
railties (>= 4.1, < 5)
sprockets (>= 2, < 4)
sprockets-rails (>= 2, < 4)
tilt
launchy (2.4.3)
addressable (~> 2.3)
lodash-rails (4.16.6)
Expand All @@ -176,7 +163,7 @@ GEM
mime-types-data (~> 3.2015)
mime-types-data (3.2016.0521)
mini_portile2 (2.1.0)
minitest (5.9.1)
minitest (5.10.0)
multi_fetch_fragments (0.0.17)
multi_json (1.12.1)
multi_xml (0.5.5)
Expand Down Expand Up @@ -336,10 +323,6 @@ GEM
json (>= 1.8, < 3)
simplecov-html (~> 0.10.0)
simplecov-html (0.10.0)
sinon-chai-rails (1.2.0)
railties (>= 3.1)
sinon-rails (1.15.0)
railties (>= 3.1)
spring (2.0.0)
activesupport (>= 4.2)
spring-commands-rspec (1.0.4)
Expand Down Expand Up @@ -376,7 +359,7 @@ GEM
ethon (>= 0.9.0)
tzinfo (1.2.2)
thread_safe (~> 0.1)
uglifier (3.0.3)
uglifier (3.0.4)
execjs (>= 0.3.0, < 3)
unf (0.1.4)
unf_ext
Expand All @@ -403,14 +386,12 @@ DEPENDENCIES
bootstrap-sass
brakeman
bugsnag
chai-jquery-rails
christmas_tree_formatter
codeclimate-test-reporter
coffee-rails
dalli
database_cleaner
draper
ejs
factory_girl_rails
faker
figaro
Expand All @@ -421,7 +402,6 @@ DEPENDENCIES
jquery-datetimepicker-rails
jquery-rails
kaminari
konacha
launchy
lodash-rails
meta_request
Expand Down Expand Up @@ -452,8 +432,6 @@ DEPENDENCIES
shoulda-matchers
simple_form
simplecov
sinon-chai-rails
sinon-rails
spring
spring-commands-rspec
timecop
Expand Down
4 changes: 0 additions & 4 deletions Readme.md
Expand Up @@ -123,10 +123,6 @@ Standard RSpec/Capybara tests are used for testing the application. The tests ca

You can set up the test environment with `bundle exec rake db:test:prepare`, which will create the test DB and populate its schema automatically. You don't need to do this for every test run, but it will let you easily keep up with migrations. If you find a large number of tests are failing you should probably run this.

Mocha/Konacha is used for unit testing any JavaScript. JavaScript specs
should be placed in `spec/javascripts`. Run the JavaScript specs with
`bundle exec rake konacha:serve`.

If you are using the omniauth environment variables
(GITHUB_KEY, GITHUB_SECRET, TWITTER_KEY, TWITTER_SECRET)
for **another** project, you will need to either
Expand Down
6 changes: 0 additions & 6 deletions config/initializers/konacha.rb

This file was deleted.

56 changes: 0 additions & 56 deletions spec/javascripts/emojify_spec.js

This file was deleted.

5 changes: 0 additions & 5 deletions spec/javascripts/spec_helper.js.coffee

This file was deleted.