require non empty index key

256dpi · Aug 30, 2021 · 74916aa · 74916aa
1 parent d99c9fa
commit 74916aa
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/indexes_test.go b/indexes_test.go
@@ -118,8 +118,15 @@ func TestIndexViewCreateOne(t *testing.T) {
 		assert.NoError(t, err)
 		assert.Equal(t, []bson.M{}, readAll(csr))
 
-		// invalid index
+		// empty index
 		name, err := c.Indexes().CreateOne(nil, mongo.IndexModel{
+			Keys: bson.M{},
+		})
+		assert.Error(t, err)
+		assert.Empty(t, name)
+
+		// invalid index
+		name, err = c.Indexes().CreateOne(nil, mongo.IndexModel{
 			Keys: bson.M{
 				"bar": false,
 			},

diff --git a/mongokit/index.go b/mongokit/index.go
@@ -95,6 +95,11 @@ type Index struct {
 
 // CreateIndex will create and return a new index.
 func CreateIndex(config IndexConfig) (*Index, error) {
+	// check key
+	if len(*config.Key) == 0 {
+		return nil, fmt.Errorf("empty index key")
+	}
+
 	// clone key and partial
 	config.Key = bsonkit.Clone(config.Key)
 	config.Partial = bsonkit.Clone(config.Partial)

diff --git a/mongokit/index_test.go b/mongokit/index_test.go
@@ -18,10 +18,15 @@ func mustHas(ok bool, err error) bool {
 }
 
 func TestIndex(t *testing.T) {
+	index, err := CreateIndex(IndexConfig{
+		Key: bsonkit.MustConvert(bson.M{}),
+	})
+	assert.Error(t, err)
+
 	d1 := bsonkit.MustConvert(bson.M{"a": "1"})
 	d2 := bsonkit.MustConvert(bson.M{"a": "1"})
 
-	index, err := CreateIndex(IndexConfig{
+	index, err = CreateIndex(IndexConfig{
 		Key: bsonkit.MustConvert(bson.M{
 			"a": int32(1),
 		}),