-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Chinese translation strings.xml #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
test for actions
@Tribbtsz Why are you pushing changes that are not related to this PR at all? Detekt shouldn't have to be disabled in order to push some translations?? I am able to cherry-pick your translations onto ViTune master, if you want. |
@Tribbtsz I'm sorry, I see that you tried out GitHub workflows in order to test this yourself, then tried to delete it by creating a delete commit. I guess I can squash and merge this PR, let me review the actual translations... |
Please do note though that full Chinese support is not possible, as YouTube Music is not available in China and therefore doesn't provide Chinese content. (closes #359) |
Oh my goodness, this is not what I wanted. I messed everything up. The subsequent commits were not what I intended. I was trying to do some testing in the repository I had forked (attempting to use workflow to package the APK), but I didn't realize these commits would affect this PR. If possible, could you please only focus on the changes in the string.xml file and ignore the other commits? Or do I need to redo the previous steps? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you so much for the translations! I've formatted a bit so we can squash.
No description provided.