Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Chinese translation strings.xml #360

Merged
merged 11 commits into from
Jun 22, 2024

Conversation

Tribbtsz
Copy link

No description provided.

Copy link

@Enigma1309 Enigma1309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@25huizengek1
Copy link
Owner

@Tribbtsz Why are you pushing changes that are not related to this PR at all? Detekt shouldn't have to be disabled in order to push some translations??

I am able to cherry-pick your translations onto ViTune master, if you want.

@25huizengek1
Copy link
Owner

@Tribbtsz I'm sorry, I see that you tried out GitHub workflows in order to test this yourself, then tried to delete it by creating a delete commit. I guess I can squash and merge this PR, let me review the actual translations...

@25huizengek1
Copy link
Owner

Please do note though that full Chinese support is not possible, as YouTube Music is not available in China and therefore doesn't provide Chinese content. (closes #359)

@25huizengek1 25huizengek1 linked an issue Jun 22, 2024 that may be closed by this pull request
@Tribbtsz
Copy link
Author

Oh my goodness, this is not what I wanted. I messed everything up. The subsequent commits were not what I intended. I was trying to do some testing in the repository I had forked (attempting to use workflow to package the APK), but I didn't realize these commits would affect this PR. If possible, could you please only focus on the changes in the string.xml file and ignore the other commits? Or do I need to redo the previous steps?

Copy link
Owner

@25huizengek1 25huizengek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for the translations! I've formatted a bit so we can squash.

@25huizengek1 25huizengek1 merged commit ed176ed into 25huizengek1:master Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Chinese
3 participants