KAZOO-5923: Fix number(s) synchronisation #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesaimonetti
requested changes
Oct 11, 2018
| case not ShouldEnsureDocIsInRightAccountDb | ||
| andalso UsedBy =:= kz_json:get_ne_binary_value(?PVT_USED_BY, NumDoc) | ||
| andalso have_same_pvt_values(NumDoc, Doc) | ||
| andalso NewNumDoc =:= Doc |
There was a problem hiding this comment.
This will compare things with respect to key ordering which means {[{a, 1}, {b, 2}]} will not be equal to {[{b,2}, {a,1}]} when these should be considered equal documents. Use kz_json:are_equal(NewNumDoc, Doc) instead.
| fix_docs({error, _R}, Doc, AccountDb, _NumberDb, _DID) -> | ||
| ?SUP_LOG_DEBUG("~s disappeared from ~s (~p), deleting from AccountDb", [_DID, _NumberDb]), | ||
| case kz_datamgr:del_doc(AccountDb, Doc) of | ||
| {ok, _} -> ok; |
KAZOO-5923: use kz_json:are_equal/2 instead of the =:= operator and tickie atoms
jamesaimonetti
force-pushed
the
KAZOO-5923-4.2
branch
from
2ffb023
to
a36218d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.