Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSTR-182: Implement csvUploader common control #719

Merged
merged 2 commits into from
Aug 5, 2020
Merged

MSTR-182: Implement csvUploader common control #719

merged 2 commits into from
Aug 5, 2020

Conversation

joristirado
Copy link
Contributor

@joristirado joristirado commented Aug 3, 2020 •
edited
Loading

csvUploader

@joristirado
Implement csvUploader common control
fa612d2 
- Declare csvUploader

- Add template/style/i18n and event bindings

- Prase csv file and expose possible errors

- Parametrize common control

- Add optional csv template file functionality
@joristirado joristirado self-assigned this Aug 3, 2020
pcandia
pcandia approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@pcandia pcandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, nice job! I tested it and I didn't find any issues.

@joristirado joristirado merged commit 8204db9 into master Aug 5, 2020
@joristirado joristirado deleted the MSTR-182 branch August 5, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcandia pcandia pcandia approved these changes

Assignees

@joristirado joristirado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joristirado @pcandia