Not really rewrite mod system #1072
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SweetSea-ButImNotSweet
changed the title
SweetSea-ButImNotSweet
changed the title
Not-A-Normal-Robot
requested changes
Jan 7, 2024
Not-A-Normal-Robot
requested changes
Jan 8, 2024
Not-A-Normal-Robot
requested changes
Jan 8, 2024
Not-A-Normal-Robot
requested changes
Jan 8, 2024
|
I would suggest splitting such a large pull request into multiple pull requests, if possible, so that each pull request can focus on a single functionality and be reviewed separately. |
|
To be honest, I want to just close this pull request, but after all, I am not the one responsible for maintaining this repository, and it is kind of disrespectful to do so, so I would just wait. |
Not-A-Normal-Robot
approved these changes
Jan 10, 2024
I am doing it right now T_T |
SweetSea-ButImNotSweet
changed the title
Not-A-Normal-Robot
approved these changes
Jun 6, 2024
Comment on lines
1012
to
1014
| for _=1,20 do | ||
| coroutine.yield() | ||
| end |
There was a problem hiding this comment.
I think there's a TEST.yieldN() thing you could use instead. @MrZ626 would you recommend using that, or is that just a temporary thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1064
TODO:
P/S: Playing the replay which applied the mods after the initialization or always during game in older version may lead to desynchronization.