Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pwnie Express Pwn Pulse #2303

Merged
merged 9 commits into from Feb 21, 2017

Conversation

granolocks
Copy link
Contributor

This PR adds the Pwnie Express Device Threat Visibility Platform to the Security tools listing.

Copy link
Member

@Carlgo11 Carlgo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo is too big. Try this one instead:
pwnieexpress

@Carlgo11 Carlgo11 added the add site Issue/PR adds a site to the repo. label Jan 14, 2017
Jawshy
Jawshy previously requested changes Jan 14, 2017
tfa: Yes
software: Yes
exceptions:
text: "TFA Can be enabled on Pwn Pulse Accounts upon customer request."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to:

          text: "TFA can be enabled on Pwn Pulse Accounts upon customer request."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

software: Yes
exceptions:
text: "TFA Can be enabled on Pwn Pulse Accounts upon customer request."
doc: https://www.pwnieexpress.com/support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using that link I cannot find the documentation for how the site has implemented 2FA. Is there a direct link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is information from that page under the Pulse -- User Guide link but it links to a CDN link which always feels a little unreliable to hardlink to :

https://cdn2.hubspot.net/hubfs/421408/Pulse_User_Guide_Rev160630.pdf?t=1484262987343

Copy link
Member

@jamcat22 jamcat22 Jan 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we decide to link directly to the CDN, should we use this link?
https://cdn2.hubspot.net/hubfs/421408/Pulse_User_Guide_Rev160630.pdf?t=1484262987343#page=41
It will open directly to the page that talks about 2FA (in Acrobat+most modern browsers).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamcat22's direct link looks like the best option, but being a PDF is not ideal (for mobile users). Perhaps adding a note saying "Under "Pulse" click "User Guide" and scroll to page 41." would be a suitable alternative.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since doc isn't a required field, i think that notes for a doc seem superfluous

@granolocks
Copy link
Contributor Author

@Carlgo11 updated the image file.

@granolocks
Copy link
Contributor Author

@Jawshy updated the language and replied about the documentation link.

@Carlgo11 Carlgo11 requested a review from Jawshy January 17, 2017 21:12
Copy link
Contributor

@Jawshy Jawshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Carlgo11 Carlgo11 changed the title add pwnie express pwn pulse to security sites Add Pwnie Express Pwn Pulse Jan 26, 2017
@granolocks
Copy link
Contributor Author

bump, @Jawshy I had missed your doc request, i have removed doc

@Carlgo11 Carlgo11 requested a review from Jawshy February 3, 2017 14:02
@stephengroat
Copy link
Contributor

bump for @Jawshy

@stephengroat stephengroat dismissed Jawshy’s stale review February 21, 2017 16:39

3 bumps for re-review, can always un-merge if it's horrible

@stephengroat stephengroat merged commit e3846f4 into 2factorauth:master Feb 21, 2017
@Jawshy Jawshy removed their request for review November 16, 2017 12:42
bepstein referenced this pull request in theias/supportsso Apr 20, 2018
* add pwnie express pwn pulse to security sites

* reduce pwniee express logo image size

* fix image size

* lower case "Can" to "can"

* update image file

* Remove Pwnie Express doc: key

* remove unneeded newlines

* alphabetize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add site Issue/PR adds a site to the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants