Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SatoshiTango #2321

Merged
merged 4 commits into from Jan 24, 2017
Merged

Add SatoshiTango #2321

merged 4 commits into from Jan 24, 2017

Conversation

@aranciaga
Copy link
Contributor

@aranciaga aranciaga commented Jan 20, 2017

No description provided.

Rainbow added 2 commits Jan 20, 2017
Rainbow
Rainbow
@Jawshy Jawshy added the add site label Jan 20, 2017
Copy link
Member

@Jawshy Jawshy left a comment

@rainbowintheshell, thanks for submitting a pull request.

Does the site have any documentation about how it has implemented two-factor authentication?

@aranciaga
Copy link
Contributor Author

@aranciaga aranciaga commented Jan 20, 2017

@Jawshy Hi there,

I searched, but I found none.

@Jawshy
Copy link
Member

@Jawshy Jawshy commented Jan 20, 2017

Okay. Would you be able to screenshot the process for enabling 2FA and then attach the screenshots below? We can then use that as documentation.

@aranciaga
Copy link
Contributor Author

@aranciaga aranciaga commented Jan 20, 2017

Enabling 2-FA in SatoshiTango

Log in, and then go to Settings > Security. Then, click 'Activate'

Scan the QR Code with your mobile using Authy (or similar)

Enter the code, confirm, and you're done!

Rainbow
@Jawshy
Copy link
Member

@Jawshy Jawshy commented Jan 20, 2017

Thanks, @rainbowintheshell. Those screenshots show enabling software-based authentication. What is the process for enabling hardware-based authentication?

@aranciaga
Copy link
Contributor Author

@aranciaga aranciaga commented Jan 20, 2017

@Jawshy My mistake, It's just software-based authentication.

Rainbow
@Jawshy
Jawshy approved these changes Jan 21, 2017
Copy link
Member

@Jawshy Jawshy left a comment

👌 👍

img: satoshitango.png
tfa: Yes
software: Yes
doc: https://github.com/2factorauth/twofactorauth/pull/2321#issuecomment-273971890

This comment has been minimized.

@jamcat22

jamcat22 Jan 21, 2017
Member

I'm hesitant to add this as the doc link, considering we have a notes section on the website already for sites without pre-made docs. Should we make a new note for this site?

This comment has been minimized.

@aranciaga

aranciaga Jan 21, 2017
Author Contributor

@jamcat22 I've seen sites with similar doc links, but it's up to you guys. But, creating a note will be more cleaner than this, for sure.

EDIT: I noticed that notes doesn't have screenshots. I don't know if it's the idea, but anyway, the pics are uploaded to imgur.

This comment has been minimized.

@jamcat22

jamcat22 Jan 24, 2017
Member

I'll go ahead and merge this now, and add the PR to our backlog. This way the site appears right away, and there is a doc listed for it, but we can easily return to add a page to the notes section later. 😄

@jamcat22 jamcat22 merged commit 254a92f into 2factorauth:master Jan 24, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jamcat22 jamcat22 added the backlog label Jan 24, 2017
bepstein referenced this pull request in theias/supportsso Apr 20, 2018
* Add SatoshiTango

* compress png

* doc by me

* remove hardware auth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants