Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SatoshiTango #2321

Merged
merged 4 commits into from Jan 24, 2017
Merged

Add SatoshiTango #2321

merged 4 commits into from Jan 24, 2017

Conversation

aranciaga
Copy link

No description provided.

@Jawshy Jawshy added the add site Issue/PR adds a site to the repo. label Jan 20, 2017
Copy link
Contributor

@Jawshy Jawshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rainbowintheshell, thanks for submitting a pull request.

Does the site have any documentation about how it has implemented two-factor authentication?

@aranciaga
Copy link
Author

@Jawshy Hi there,

I searched, but I found none.

@Jawshy
Copy link
Contributor

Jawshy commented Jan 20, 2017

Okay. Would you be able to screenshot the process for enabling 2FA and then attach the screenshots below? We can then use that as documentation.

@aranciaga
Copy link
Author

Enabling 2-FA in SatoshiTango

Log in, and then go to Settings > Security. Then, click 'Activate'

Scan the QR Code with your mobile using Authy (or similar)

Enter the code, confirm, and you're done!

@Jawshy
Copy link
Contributor

Jawshy commented Jan 20, 2017

Thanks, @rainbowintheshell. Those screenshots show enabling software-based authentication. What is the process for enabling hardware-based authentication?

@aranciaga
Copy link
Author

@Jawshy My mistake, It's just software-based authentication.

Copy link
Contributor

@Jawshy Jawshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👍

img: satoshitango.png
tfa: Yes
software: Yes
doc: https://github.com/2factorauth/twofactorauth/pull/2321#issuecomment-273971890
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to add this as the doc link, considering we have a notes section on the website already for sites without pre-made docs. Should we make a new note for this site?

Copy link
Author

@aranciaga aranciaga Jan 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamcat22 I've seen sites with similar doc links, but it's up to you guys. But, creating a note will be more cleaner than this, for sure.

EDIT: I noticed that notes doesn't have screenshots. I don't know if it's the idea, but anyway, the pics are uploaded to imgur.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge this now, and add the PR to our backlog. This way the site appears right away, and there is a doc listed for it, but we can easily return to add a page to the notes section later. 😄

@jamcat22 jamcat22 merged commit 254a92f into 2factorauth:master Jan 24, 2017
@jamcat22 jamcat22 added the backlog PR closed but not merged. A new PR should be made that adds/updates the sites from the old one. label Jan 24, 2017
bepstein referenced this pull request in theias/supportsso Apr 20, 2018
* Add SatoshiTango

* compress png

* doc by me

* remove hardware auth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add site Issue/PR adds a site to the repo. backlog PR closed but not merged. A new PR should be made that adds/updates the sites from the old one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants