-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SatoshiTango #2321
Add SatoshiTango #2321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rainbowintheshell, thanks for submitting a pull request.
Does the site have any documentation about how it has implemented two-factor authentication?
@Jawshy Hi there, I searched, but I found none. |
Okay. Would you be able to screenshot the process for enabling 2FA and then attach the screenshots below? We can then use that as documentation. |
Thanks, @rainbowintheshell. Those screenshots show enabling software-based authentication. What is the process for enabling hardware-based authentication? |
@Jawshy My mistake, It's just software-based authentication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 👍
img: satoshitango.png | ||
tfa: Yes | ||
software: Yes | ||
doc: https://github.com/2factorauth/twofactorauth/pull/2321#issuecomment-273971890 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitant to add this as the doc link, considering we have a notes section on the website already for sites without pre-made docs. Should we make a new note for this site?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamcat22 I've seen sites with similar doc links, but it's up to you guys. But, creating a note will be more cleaner than this, for sure.
EDIT: I noticed that notes doesn't have screenshots. I don't know if it's the idea, but anyway, the pics are uploaded to imgur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and merge this now, and add the PR to our backlog. This way the site appears right away, and there is a doc listed for it, but we can easily return to add a page to the notes section later. 😄
No description provided.