Implement closeApp for silverlight apps #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAb
reviewed
Nov 4, 2016
| @@ -89,6 +91,25 @@ public string DeviceName | |||
|
|
|||
| #region Public Methods and Operators | |||
|
|
|||
| public static AppType DetermineAppType(string packagePath) | |||
NickAb
reviewed
Nov 4, 2016
| var remoteCommand = new Command(DriverCommand.CloseApp); | ||
| automator.CommandForwarder.ForwardCommand(remoteCommand); | ||
| Thread.Sleep(TimeSpan.FromMilliseconds(500)); | ||
| if (automator.Deployer.AppType == AppType.XAP) |
There was a problem hiding this comment.
Maybe we should add IsTerminatable into Deployer? At the moment this condition is basically duplicated both her and in Deployer.
Or we can make Terminate return a bool: true if it can and did in fact terminated the app, false if it can not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.