Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy for deprecated api versions #126

Merged
merged 1 commit into from
May 13, 2020
Merged

Conversation

seleznev
Copy link
Collaborator

@seleznev seleznev commented May 8, 2020

Deprecation checker currently silently blocks provisioning because of wrong placed DeprecationError exception handler:

except DeprecationError as e:
log.warning('Deprecation warning: {}'.format(e))

But it should be handled somewhere around:

except client.api_client.ApiException:
log.warning("Error while getting API version, deprecation check will be skipped.")
).

So, I suggest to remove exception completely.

@seleznev seleznev added bug Something isn't working P0 Need to fix ASAP labels May 8, 2020
@seleznev seleznev self-assigned this May 8, 2020
@dcleric
Copy link

dcleric commented May 12, 2020

@furiousassault plz review

Copy link
Collaborator

@furiousassault furiousassault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@furiousassault
Copy link
Collaborator

It would be good to check if _is_deprecated is still used somewhere, btw.

@seleznev seleznev merged commit 0bf1afd into master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Need to fix ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants