Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease uptime check frequency #2347

Merged
merged 1 commit into from Mar 14, 2023
Merged

Decrease uptime check frequency #2347

merged 1 commit into from Mar 14, 2023

Conversation

pnasrat
Copy link
Contributor

@pnasrat pnasrat commented Mar 13, 2023

See #2320

Deployment needs to be manual to destroy then create

@pnasrat
Decrease uptime check frequency and reduce check locations
dc27711 
See #2320

Deployment needs to be manual to destroy then create
@pnasrat pnasrat changed the title Decrease uptime check frequency and reduce check locations Decrease uptime check frequency Mar 13, 2023
@damianavila damianavila requested a review from a team March 13, 2023 17:16
consideRatio
consideRatio approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and I think an already existing comment motivates this change:

This shoulod prevent alerts if the hub is momentarily down during a deployment. All alerts must be actionable, so we trade-off some latency here for resiliency.

@pnasrat
Copy link
Contributor Author

pnasrat commented Mar 14, 2023

Have manually deployed and update checks created (checked in console)

@pnasrat pnasrat merged commit d8f3aa6 into master Mar 14, 2023
1 check passed
@pnasrat pnasrat deleted the uptime-check-limit-regions branch March 14, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees

@pnasrat pnasrat

Labels
None yet
Projects
Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pnasrat @consideRatio