Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find and replace within TinyMCE in the edit modal is cut off #2321

Closed
ajplopez opened this issue Jan 8, 2021 · 4 comments
Closed

Find and replace within TinyMCE in the edit modal is cut off #2321

ajplopez opened this issue Jan 8, 2021 · 4 comments

Comments

@ajplopez
Copy link
Sponsor

ajplopez commented Jan 8, 2021

I*I'm submitting a ...**
[x] bug report

...about
[x] edit experience / UI

Current behavior

When you open up the edit modal and go to use the TinyMCE, the find and replace modal is cut off and you can't move it into place. This happens in both inline and full mode. See screenshots.

Screen Shot 2021-01-08 at 11 34 09 AM
Screen Shot 2021-01-08 at 11 34 17 AM

Expected behavior
It shouldn't be cut off

Minimal reproduction of the problem with instructions
Make a content modal with a TinyMCE. Try to do Ctrl + F / Cmd + F in the edit mode and you'll see it appears off screen.

What is the motivation / use case for changing the behavior?
Client asked me about doing find and replace and we discovered this is available in TinyMCE but it's hidden.

Please tell us about your environment:

  • 2sxc version(s): 11.11.3
  • Browser: [all ]
  • DNN: [9.3.2 ]
  • Language: [any/all ]

Anything you would like to add

@PagnoDunadan
Copy link
Contributor

PagnoDunadan commented Jan 19, 2021

Fixed.
image

@iJungleboy
Copy link
Contributor

Our fix for find/replace causes other issues and breaks all context-menus and other menus #2333. Because of this we must undo our fix (so reopen this issue) to fix #2333.

@iJungleboy iJungleboy reopened this Jan 28, 2021
2sxc from 11.07 LTS to 11.22 LTS automation moved this from In 11.11.03 WIP to In progress Jan 28, 2021
@iJungleboy
Copy link
Contributor

This will need some trickery to be fixed. As it's not on our priorities, someone else must do this.

Since the dialog itself doesn't have a unique class to target, it would need a JS mutationObserver which watches for the dialog to open and apply the CSS, without accidentally breaking the other dialogs.

To do this reliably we must then verify that everything else isn't affected - so will need 2-4h.

Since we won't be addressing this ourselves, I'll put it on the needs-contribution list and close for now.

@PagnoDunadan
Copy link
Contributor

PagnoDunadan commented Apr 21, 2021

Should be a lot better in the next release because TinyMCE team fixed the issue on their end.

In inline mode you have to scroll to use it:
image

In dialog mode it works great:
image

Also, option is available from the menu as well:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants