Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-org new Razor12 classes to have new APIs, and ensure old ones don't #2540

Closed
iJungleboy opened this issue Oct 4, 2021 · 0 comments
Closed

Comments

@iJungleboy
Copy link
Contributor

I'm submitting a ...
[x] Refactor request

...about
[x] Razor templating
[x] Custom C# APIs

Current behavior

2sxc 12 introduces a few new APIs like Settings, Resources and Convert. This could cause trouble in old code, which may have used terms like Convert already. For example, old code could have Convert.ToInt32 which is a System.Convert object.

Expected behavior

New razor inheriting from Custom.Hybrid.Razor12 or Custom.Dnn.Razor12 should get these new commands, older base classes should not.

Why change the behavior?

It's too risky that we would break very old code which already used terms like Convert or Settings.

Your environment

  • 2sxc version(s): 12.04
@iJungleboy iJungleboy self-assigned this Oct 4, 2021
@iJungleboy iJungleboy added this to To do in 2sxc 12.00 to 2sxc 12.08 LTS via automation Oct 4, 2021
iJungleboy added a commit that referenced this issue Oct 4, 2021
iJungleboy added a commit that referenced this issue Oct 5, 2021
2sxc 12.00 to 2sxc 12.08 LTS automation moved this from To do to Done Oct 6, 2021
@iJungleboy iJungleboy moved this from Done to V12.05 in 2sxc 12.00 to 2sxc 12.08 LTS Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant