Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Support for UseFileVersion and OverwriteFileVersion #48

Closed
wants to merge 4 commits into from
Closed

Support for UseFileVersion and OverwriteFileVersion #48

wants to merge 4 commits into from

Conversation

304NotModified
Copy link
Owner

@304NotModified 304NotModified commented Sep 3, 2018 •
edited

This branch addresses #13 by adding two config options:

  1. OverwriteFileVersion is set to true by default. If it is set to false, Stamp will not overwrite the AssemblyFileVersion with the AssemblyVersion.
  2. UseFileVersion is false by default. If it is set to true, Stamp will use AssemblyFileVersion to construct the AssemblyInformationalVersion, rather than using AssemblyVersion. Also, if this is set to true, OverwriteFileVersion will be false and will ignore any explicitly set value.

I included tests for both of these options that mimic TaskTests.

Fixes #13, supersedes #22

to do:

  • rebased
  • backwardscompatible
  • rename UseFileVersion? -> AssemblyInformationalSource = AssemblyVersion | AssemblyFileVersion
  • OverwriteFileVersion? -> PreserveFileVersion

readme: https://github.com/304NotModified/Fody.Stamp/tree/pr22b

@304NotModified 304NotModified added this to the 2.0 milestone Sep 3, 2018
@304NotModified 304NotModified mentioned this pull request Sep 3, 2018
Closed
@304NotModified 304NotModified modified the milestones: 2.0, 1.5 Sep 3, 2018
@304NotModified 304NotModified removed this from the 1.5 milestone Jan 24, 2019
@304NotModified
Copy link
Owner Author

superseded by #54

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @asherber