Modify file path mapping so that it works on windows #12
+108
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
commented
Sep 24, 2022
| return Remap(path, _workspaceBasePath, _compilerLogBasePath); | ||
| } | ||
|
|
||
| public static string Remap(string path, string workspacePath, string compilerLogBasePath) |
There was a problem hiding this comment.
haven't really tested on unix (or done a lot of validation on this). Might not be right, but hopeuflly describes the problems well
dibarbet
force-pushed
the
file_path_remap
branch
from
821409c
to
e8a86d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.