Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support the format used in Google Photos which utilizes XMP metadata #43

Merged
merged 13 commits into from
May 23, 2024

Conversation

34j
Copy link
Owner

@34j 34j commented May 18, 2024

Description of change

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • This pull request follows Contributing.md
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec, such as "fix(api): prevent racing of requests".
  • If pre-commit.ci is failing, try pre-commit run -a for further information.
  • If CI / test is failing, try poetry run pytest for further information.

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 3.57143% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 56.87%. Comparing base (a7d64a8) to head (6ef4bf8).

Files Patch % Lines
src/vr180_convert/cli.py 3.57% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   63.07%   56.87%   -6.20%     
==========================================
  Files           6        6              
  Lines         482      538      +56     
  Branches       92       98       +6     
==========================================
+ Hits          304      306       +2     
- Misses        154      208      +54     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@34j 34j merged commit 7a58f06 into main May 23, 2024
18 checks passed
@34j 34j deleted the feat/xmp branch May 23, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant