Skip to content

Commit

Permalink
Remove add-module-exports (Fix #120) (#122)
Browse files Browse the repository at this point in the history
Closed #121
  • Loading branch information
3846masa committed Dec 8, 2017
1 parent 945c82a commit e250fd9
Show file tree
Hide file tree
Showing 10 changed files with 51 additions and 17 deletions.
1 change: 0 additions & 1 deletion .babelrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"plugins": [
"add-module-exports",
"module:@babel/plugin-transform-modules-commonjs",
[
"module:fast-async",
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ $ npm i axios axios-cookiejar-support # Same as above
## Usage

```js
const axios = require('axios');
const axiosCookieJarSupport = require('@3846masa/axios-cookiejar-support');
// const axiosCookieJarSupport = require('axios-cookiejar-support');
const axios = require('axios').default;
const axiosCookieJarSupport = require('@3846masa/axios-cookiejar-support').default;
// const axiosCookieJarSupport = require('axios-cookiejar-support').default;
const tough = require('tough-cookie');

axiosCookieJarSupport(axios);
Expand Down
4 changes: 2 additions & 2 deletions example/send-cookies.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';

const axios = require('axios');
const axios = require('axios').default;
const tough = require('tough-cookie');
const axiosCookieJarSupport = require('../');
const axiosCookieJarSupport = require('../').default;

axiosCookieJarSupport(axios);

Expand Down
4 changes: 2 additions & 2 deletions example/set-default.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';

const axios = require('axios');
const axios = require('axios').default;
const tough = require('tough-cookie');
const axiosCookieJarSupport = require('../');
const axiosCookieJarSupport = require('../').default;

axiosCookieJarSupport(axios);

Expand Down
4 changes: 2 additions & 2 deletions example/simple.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';

const axios = require('axios');
const axios = require('axios').default;
const tough = require('tough-cookie');
const axiosCookieJarSupport = require('../');
const axiosCookieJarSupport = require('../').default;

axiosCookieJarSupport(axios);

Expand Down
20 changes: 20 additions & 0 deletions example/simple.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import axios from 'axios';
import tough from 'tough-cookie';
import axiosCookieJarSupport from '../';

axiosCookieJarSupport(axios);

const cookieJar = new tough.CookieJar();

axios
.get('https://google.com', {
jar: cookieJar,
withCredentials: true,
})
.then(response => {
const config = response.config;
console.log(config.jar.toJSON());
})
.catch(err => {
console.error(err.stack || err);
});
20 changes: 20 additions & 0 deletions example/simple.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import axios from 'axios';
import tough = require('tough-cookie');
import axiosCookieJarSupport from '../';

axiosCookieJarSupport(axios);

const cookieJar = new tough.CookieJar();

axios
.get('https://google.com', {
jar: cookieJar,
withCredentials: true,
})
.then(response => {
const config = response.config;
console.log(config.jar.toJSON());
})
.catch(err => {
console.error(err.stack || err);
});
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
"@babel/core": "^7.0.0-beta.32",
"@babel/plugin-transform-modules-commonjs": "^7.0.0-beta.32",
"axios": "0.17.1",
"babel-plugin-add-module-exports": "^0.2.1",
"cookie": "0.3.1",
"decache": "4.3.0",
"eslint": "4.12.0",
Expand Down
4 changes: 2 additions & 2 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ const nock = require('nock');
const tough = require('tough-cookie');
const cookie = require('cookie');
const decache = require('decache');
const axiosCookieJarSupport = require('../');
const axiosCookieJarSupport = require('../').default;

let axios;
beforeEach(() => {
decache('axios');
axios = require('axios');
axios = require('axios').default;
axios.defaults.validateStatus = () => true;
});

Expand Down
4 changes: 0 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -321,10 +321,6 @@ babel-code-frame@^6.22.0:
esutils "^2.0.2"
js-tokens "^3.0.2"

babel-plugin-add-module-exports@^0.2.1:
version "0.2.1"
resolved "https://registry.yarnpkg.com/babel-plugin-add-module-exports/-/babel-plugin-add-module-exports-0.2.1.tgz#9ae9a1f4a8dc67f0cdec4f4aeda1e43a5ff65e25"

babylon@7.0.0-beta.32:
version "7.0.0-beta.32"
resolved "https://registry.yarnpkg.com/babylon/-/babylon-7.0.0-beta.32.tgz#e9033cb077f64d6895f4125968b37dc0a8c3bc6e"
Expand Down

0 comments on commit e250fd9

Please sign in to comment.