Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for RetroCL exclude attrs missing dependency #4791

Closed
jchapma opened this issue Jun 3, 2021 · 1 comment · Fixed by #4792
Closed

Workaround for RetroCL exclude attrs missing dependency #4791

jchapma opened this issue Jun 3, 2021 · 1 comment · Fixed by #4792
Assignees
@jchapma

Comments

@jchapma
Copy link
Contributor

jchapma commented Jun 3, 2021

Issue Description
The RetroCL exclude attribute RFE is dependent on the functionality of a EntryUUID bug fix that didn't make into the latest build. This breaks the RetroCL change so we need to provide a workaround.

RetroCL RFE
#4723

EntryUUID
#4224

Affected branches:

  • 389-ds-base-1.4.3
  • 389-ds-base-1.4.4

Steps to Reproduce

  1. Go 389-ds-base-1.4.3 branch
  2. Run retrocl CI test - sudo pytest -s -v dirsrvtests/tests/suites/retrocl/basic_test.py
  3. See error detailing missing dependency

Expected results
The retrocl CI test should pass
@jchapma jchapma added the needs triage The issue will be triaged during scrum label Jun 3, 2021
@jchapma jchapma self-assigned this Jun 3, 2021
@jchapma
Copy link
Contributor Author

jchapma commented Jun 3, 2021

@tbordaz @droideck

@jchapma jchapma removed the needs triage The issue will be triaged during scrum label Jun 3, 2021
@jchapma jchapma changed the title Work around for missing dependency Workaround for RetroCL exclude attrs missing dependency Jun 3, 2021
@jchapma jchapma mentioned this issue Jun 3, 2021
Merged
jchapma added a commit to jchapma/389-ds-base that referenced this issue Jun 14, 2021
@jchapma
Issue 4791 - Missing dependency for RetroCL RFE
dcbcfd7 
Description: The RetroCL exclude attribute RFE is dependent on functionality of the
	     EntryUUID bug fix, that didn't make into the latest build. This breaks the
             RetroCL exclude attr feature so we need to provide a workaround.

Fixes: 389ds#4791

Relates: 389ds#4723

Relates: 389ds#4224

Reviewed by: tbordaz, droideck (Thank you)
jchapma added a commit that referenced this issue Jun 14, 2021
@jchapma
Issue 4791 - Missing dependency for RetroCL RFE (#4792)
f542f89 
Description: The RetroCL exclude attribute RFE is dependent on functionality of the
	     EntryUUID bug fix, that didn't make into the latest build. This breaks the
             RetroCL exclude attr feature so we need to provide a workaround.

Fixes: #4791

Relates: #4723

Relates: #4224

Reviewed by: tbordaz, droideck (Thank you)
jchapma added a commit that referenced this issue Jun 15, 2021
@jchapma
Issue 4791 - Missing dependency for RetroCL RFE
d5896fb 
Description: The RetroCL exclude attribute RFE is dependent on functionality of the
	     EntryUUID bug fix, that didn't make into the latest build. This breaks the
             RetroCL exclude attr feature so we need to provide a workaround.

Fixes: #4791

Relates: #4723

Relates: #4224

Reviewed by: tbordaz, droideck (Thank you)
@jchapma jchapma mentioned this issue Nov 8, 2021
Closed
jchapma added a commit to jchapma/389-ds-base that referenced this issue Nov 8, 2021
@jchapma
Issue 4994 - Revert retrocl dependency workaround
fb06ba9 
Description: The RetroCL exclude attribute RFE was dependent on the
functionality of a commit that didn't make into the rhel 8.5 build. A
work around was committed that added the missing methods.

Since then the previous commit has been merged, so there now exists two
definitions of the same method, these need to be removed.

fixes: 389ds#4994

relates: 389ds#4791

Reviewed by: ?
@jchapma jchapma mentioned this issue Nov 8, 2021
Merged
jchapma added a commit that referenced this issue Dec 9, 2021
@jchapma
Issue 4994 - Revert retrocl dependency workaround (#4995)
bd5c39b 
Description: The RetroCL exclude attribute RFE was dependent on the
functionality of a commit that didn't make into the rhel 8.5 build. A
work around was committed that added the missing methods.

Since then the previous commit has been merged, so there now exists two
definitions of the same method, these need to be removed.

fixes: #4994

relates: #4791

Reviewed by: tbordaz (Merci)
jchapma added a commit that referenced this issue Jan 13, 2022
@jchapma
Issue 4994 - Revert retrocl dependency workaround (#4995)
039bc99 
Description: The RetroCL exclude attribute RFE was dependent on the
functionality of a commit that didn't make into the rhel 8.5 build. A
work around was committed that added the missing methods.

Since then the previous commit has been merged, so there now exists two
definitions of the same method, these need to be removed.

fixes: #4994

relates: #4791

Reviewed by: tbordaz (Merci)
jchapma added a commit that referenced this issue Jan 13, 2022
@jchapma
Issue 4994 - Revert retrocl dependency workaround (#4995)
924c736 
Description: The RetroCL exclude attribute RFE was dependent on the
functionality of a commit that didn't make into the rhel 8.5 build. A
work around was committed that added the missing methods.

Since then the previous commit has been merged, so there now exists two
definitions of the same method, these need to be removed.

fixes: #4994

relates: #4791

Reviewed by: tbordaz (Merci)
jchapma added a commit that referenced this issue Jan 13, 2022
@jchapma
Issue 4994 - Revert retrocl dependency workaround (#4995)
74c93fc 
Description: The RetroCL exclude attribute RFE was dependent on the
functionality of a commit that didn't make into the rhel 8.5 build. A
work around was committed that added the missing methods.

Since then the previous commit has been merged, so there now exists two
definitions of the same method, these need to be removed.

fixes: #4994

relates: #4791

Reviewed by: tbordaz (Merci)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchapma jchapma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 4791 - Missing dependency for RetroCL RFE jchapma/389-ds-base
1 participant
@jchapma