Issue 4701 - RFE - Exclude attributes from retro changelog #4723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, a few minor issues, but it looks good to me. |
droideck
requested changes
Apr 15, 2021
|
Oh, and put the test to the testing tier, please. So it will run in the GitHub CI. You can do this similar to this test suite: Just by adding this line: |
ASAN run is clean |
jchapma
force-pushed
the
issue-4701-retrocl
branch
from
ac927d1
to
d56115d
Compare
jchapma
force-pushed
the
issue-4701-retrocl
branch
from
d56115d
to
550703d
Compare
Description: When the retro changelog plugin is enabled it writes the
added/modified values to the "cn-changelog" suffix. In
some cases an entries attribute values can be of a
sensitive nature and should be excluded. This RFE adds
functionality that will allow an admin exclude certain
attributes from the retro changelog DB.
Relates: 389ds#4701
Reviewed by: mreynolds389, droideck (Thanks folks)
jchapma
force-pushed
the
issue-4701-retrocl
branch
from
550703d
to
49803a9
Compare
jchapma
commented
Apr 22, 2021
| log.fatal("Changelog search failed, error: " +str(e)) | ||
| assert False | ||
|
|
||
| def test_retrocl_exclude_attr_mod(topology_st): |
There was a problem hiding this comment.
Modify operation test added
jchapma
commented
Apr 22, 2021
| @@ -424,6 +430,15 @@ entry2reple(Slapi_Entry *e, Slapi_Entry *oe, int optype) | |||
| } | |||
| slapi_entry_add_values(e, retrocl_changetype, vals); | |||
|
|
|||
| /* Does this entry contain any excluded attributes */ | |||
| for (attrs = oe->e_attrs; attrs != NULL; attrs = attrs->a_next) { | |||
There was a problem hiding this comment.
Line 434 -> 440 are the bug fix changes
jchapma
added a commit
to jchapma/389-ds-base
that referenced
this pull request
Apr 30, 2021
Description: When the retro changelog plugin is enabled it writes the
added/modified values to the "cn-changelog" suffix. In
some cases an entries attribute values can be of a
sensitive nature and should be excluded. This RFE adds
functionality that will allow an admin exclude certain
attributes from the retro changelog DB.
Relates: 389ds#4701
Reviewed by: mreynolds389, droideck (Thanks folks)
jchapma
added a commit
that referenced
this pull request
Apr 30, 2021
…4746) Description: When the retro changelog plugin is enabled it writes the added/modified values to the "cn-changelog" suffix. In some cases an entries attribute values can be of a sensitive nature and should be excluded. This RFE adds functionality that will allow an admin exclude certain attributes from the retro changelog DB. Relates: #4701 Reviewed by: mreynolds389, droideck (Thanks folks)
jchapma
added a commit
that referenced
this pull request
Apr 30, 2021
Description: When the retro changelog plugin is enabled it writes the
added/modified values to the "cn-changelog" suffix. In
some cases an entries attribute values can be of a
sensitive nature and should be excluded. This RFE adds
functionality that will allow an admin exclude certain
attributes from the retro changelog DB.
Relates: #4701
Reviewed by: mreynolds389, droideck (Thanks folks)
jchapma
added a commit
to jchapma/389-ds-base
that referenced
this pull request
Jun 14, 2021
Description: The RetroCL exclude attribute RFE is dependent on functionality of the
EntryUUID bug fix, that didn't make into the latest build. This breaks the
RetroCL exclude attr feature so we need to provide a workaround.
Fixes: 389ds#4791
Relates: 389ds#4723
Relates: 389ds#4224
Reviewed by: tbordaz, droideck (Thank you)
jchapma
added a commit
that referenced
this pull request
Jun 14, 2021
Description: The RetroCL exclude attribute RFE is dependent on functionality of the
EntryUUID bug fix, that didn't make into the latest build. This breaks the
RetroCL exclude attr feature so we need to provide a workaround.
Fixes: #4791
Relates: #4723
Relates: #4224
Reviewed by: tbordaz, droideck (Thank you)
jchapma
added a commit
that referenced
this pull request
Jun 15, 2021
Description: The RetroCL exclude attribute RFE is dependent on functionality of the
EntryUUID bug fix, that didn't make into the latest build. This breaks the
RetroCL exclude attr feature so we need to provide a workaround.
Fixes: #4791
Relates: #4723
Relates: #4224
Reviewed by: tbordaz, droideck (Thank you)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: When the retro changelog plugin is enabled it writes the
added/modified values to the "cn-changelog" suffix. In
some cases an entries attribute values can be of a
sensitive nature and should be excluded. This RFE adds
functionality that will allow an admin exclude certain
attributes from the retro changelog DB.
Relates: #4701
Reviewed by: ??