-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 4803 - Improve DB Locks Monitoring Feature Descriptions #4810
Conversation
Description: The description of the field "nsslapd-db-locks-monitoring-threshold" is unclear. Make the explanations more detailed and concise in both CLI and Web UI. Fixes: #4803 Reviewed by: ?
Descriptions are looking good to me. Should they also mention the default value ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Simon, very clear explanation, I am just concerned about the sentence:
It helps to avoid DB corruption and long recovery.
It is either saying too little or too much.
I would here rather write:
This threshold is a safeguard against DB corruption which might be caused by locks exhaustion.
or get rid of it, if the field description is too long.
Description: Enchance one line for the threshold setting as per comment in 389ds/389-ds-base#4810 Relates: 389ds/389-ds-base#4803 Reviewed by: @droideck (one line rule)
Description: The description of the field "nsslapd-db-locks-monitoring-threshold"
is unclear. Make the explanations more detailed and concise in both CLI
and Web UI.
Fixes: #4803
Reviewed by: ?