Issue 4803 - Improve DB Locks Monitoring Feature Descriptions #4810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: The description of the field "nsslapd-db-locks-monitoring-threshold" is unclear. Make the explanations more detailed and concise in both CLI and Web UI. Fixes: #4803 Reviewed by: ?
|
Descriptions are looking good to me. Should they also mention the default value ? |
EmmanuelKasper
suggested changes
Jun 23, 2021
There was a problem hiding this comment.
Thanks Simon, very clear explanation, I am just concerned about the sentence:
It helps to avoid DB corruption and long recovery.
It is either saying too little or too much.
I would here rather write:
This threshold is a safeguard against DB corruption which might be caused by locks exhaustion.
or get rid of it, if the field description is too long.
droideck
added a commit
that referenced
this pull request
Jun 23, 2021
droideck
added a commit
that referenced
this pull request
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The description of the field "nsslapd-db-locks-monitoring-threshold"
is unclear. Make the explanations more detailed and concise in both CLI
and Web UI.
Fixes: #4803
Reviewed by: ?