Backport of accept thread to 389-ds-base-1.4.3 #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue 4506 - RFE - connection accept thread Bug Description: Previously we accepted connections and selected for new work in the same event loop. This could cause connection table polling to delay accepts, and accepts to delay connection activity from being ready. Fix Description: This seperates those functions allowing accept to occur in parallel to our normal work. fixes: 389ds#4506 Author: William Brown <william@blackhats.net.au> Review by: @mreynolds389 @progier389 (Thanks!)
Bug Description: during review it was requested that a piece of code be changed which seemed quite innocent. The code was moved but the logic around the code wasn't considered causing the fd array for the accept thread to be allocated with a size of zero, causing the values to be lost. Fix Description: Move the allocation to the correct location. fixes: 389ds#4506 Author: William Brown <william@blackhats.net.au> Review by: @mreynolds389 @droideck
|
Good catch, my previous ack stands :) |
droideck
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial PR (#4865) for this backport auto closed when I pushed a second commit...