Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of accept thread to 389-ds-base-1.4.3 #4870

Merged
merged 2 commits into from
Aug 16, 2021

Commits on Aug 11, 2021

  1. Issue 4506 - Temporary fix for io issues (389ds#4516)

    Issue 4506 - RFE - connection accept thread
    
    Bug Description: Previously we accepted connections and
    selected for new work in the same event loop. This could
    cause connection table polling to delay accepts, and
    accepts to delay connection activity from being ready.
    
    Fix Description: This seperates those functions allowing
    accept to occur in parallel to our normal work.
    
    fixes: 389ds#4506
    
    Author: William Brown <william@blackhats.net.au>
    
    Review by: @mreynolds389 @progier389 (Thanks!)
    Firstyear authored and jchapma committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    051ce51 View commit details
    Browse the repository at this point in the history
  2. Issue 4506 - BUG - fix oob alloc for fds (389ds#4555)

    Bug Description: during review it was requested that a piece
    of code be changed which seemed quite innocent. The code was
    moved but the logic around the code wasn't considered
    causing the fd array for the accept thread to be allocated with
    a size of zero, causing the values to be lost.
    
    Fix Description: Move the allocation to the correct location.
    
    fixes: 389ds#4506
    
    Author: William Brown <william@blackhats.net.au>
    
    Review by: @mreynolds389 @droideck
    Firstyear authored and jchapma committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    a09757e View commit details
    Browse the repository at this point in the history