Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5052 - BUG - Custom filters prevented entry deletion #5060

Merged
merged 1 commit into from
May 10, 2023

Commits on Dec 14, 2021

  1. Issue 5052 - BUG - Custom filters prevented entry deletion

    Bug Description: When a custom filter was provided, entries
    which were deleted in AD did not have that event correctly
    reflected in 389-ds. This was due to the behaviour that when
    an entry in AD is deleted, it is marked with a "deleted" flag
    which the objectClass=* filter would (accidentally) collect
    when it did a search. However, a custom user filter being
    specified would in some cases (such as a memberOf filter)
    NOT show up the deletion since the entry was considered
    to have moved out of scope rather than being a full delete.
    
    Fix Description: In the case that we have a userfilter, we
    wrap it in an OR condition that always requests isDeleted
    flags so that we can correctly reflect the delete status.
    
    fixes: 389ds#5052
    
    Author: William Brown <william@blackhats.net.au>
    
    Review by: ???
    Firstyear committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    5b11003 View commit details
    Browse the repository at this point in the history