Issue 5332 - BUG - normalise filter as intended #5341
Conversation
Bug Description: Due to a mistake in the optimiser rework the filter as intended was not normalised, causing some searches to fail Fix Description: Always normalise both filters. fixes: 389ds#5332 Author: William Brown <william@blackhats.net.au> Review by: ???
There was a problem hiding this comment.
Your latest PR does fix the issue, but there is a minor compiler warning I'd like you to fix:
../389-ds-base/ldap/servers/slapd/back-ldbm/ldbm_search.c: In function ‘ldbm_back_next_search_entry’:
../389-ds-base/ldap/servers/slapd/back-ldbm/ldbm_search.c:1481:13: warning: unused variable ‘val’ [-Wunused-variable]
1481 | int val = 1;
| ^~~
|
I also added a test case for you in the original issue: |
|
I don't have time to merge/review this due to having to work on some SUSE customer issues atm. |
It's all good, but I made a mistake by doing Fedora builds with the incomplete fix a few days ago and it broke other projects. So I created a duplicate PR (#5342) of this with the updated CI test and compiler warning fix (it's signed off, so you are still the author). Anyway I am going to close this PR and merge my PR tonight (and do new builds). Thanks again for working on this! |
Bug Description: Due to a mistake in the optimiser rework
the filter as intended was not normalised, causing some searches
to fail
Fix Description: Always normalise both filters.
fixes: #5332
Author: William Brown william@blackhats.net.au
Review by: ???