Issue 5332 - BUG - normalise filter as intended #5342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Description: Due to a mistake in the optimiser rework the filter as intended was not normalised, causing some searches to fail Fix Description: Always normalise both filters. fixes: 389ds#5332 Author: William Brown <william@blackhats.net.au> Review by: mreynolds (Thanks!) Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
mreynolds389
force-pushed
the
william-filter
branch
from
f5bb613
to
b5e0571
Compare
droideck
approved these changes
Jun 14, 2022
|
I think this needs backport to the other branches where we applied the optimiser? |
All done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description: Due to a mistake in the optimiser rework
the filter as intended was not normalised, causing some searches
to fail
Fix Description: Always normalise both filters.
fixes: #5332
Author: William Brown william@blackhats.net.au
Review by: mreynolds (Thanks!)
Signed-off-by: Mark Reynolds mreynolds@redhat.com