-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 5450 - schema - nsAccountLock should be single valued #5573
base: main
Are you sure you want to change the base?
Conversation
Description: nsAccountLock should be single valued fixes: 389ds#5450 Reviewed by: ?
Did you test the PR in MMR S1-S2, S1 having this change and S2 having not this change ? |
Yes I need to test replication in both directions when the schema changes. It's possible this might need to wait for schema replication improvements... |
@tbordaz - Well schema replication is not working. The consumer's schema is not updated, and I see no error messages on either replica's logs (with repl logging enabled). So I don't think it's detecting that the schema is different in regards to single vs multivalued. I'll investigate.... |
Ok if I live update the schema, then it does trigger schema replication (schema CSN was previously null after install). Then I see the failure:
It's not entirely clear to me why it failed looking at the logs. I guess it's this line:
But the other logging messages make it appear that schema replication did work. So this should be improved somehow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to approve because this change is "correct", but also could we consider as a saftey to have checks on nsAccountLock check if it's multivalue and then if any value is true, consider locked?
Description: nsAccountLock should be single valued
fixes: #5450