Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

as user who opens a scene, then opens sidebar menu, save as.. is used instead of save #275

Closed
kfarr opened this issue Sep 8, 2023 · 3 comments
Assignees

Comments

@kfarr
Copy link
Contributor

kfarr commented Sep 8, 2023

new issue from testing - as user who opens a scene (from a link or from open menu?), then uses sidebar menu (which resets hash scene ID in URL) then it will generate a new scene instead of saving as the existing scene.

depends on 3DStreet/3dstreet#335 for metadata component on scene

  • in theory there is a metadata component on a-frame scene entity which is the "source of truth" for sceneId and sceneTitle
  • this metadata component propery values sceneId and sceneTitle should always be set upon load and also synced between the react app and the a-frame component
  • in the short-term we could use set Toolbar state to sceneId upon load from open dialog, but not from page load that doesn't involve the open dialog
  • we should create a high priority ticket for alex to create a metadata component on scene entity. this should be populated by streetmix-loader and the 3dstreet json scene loader. If opening streetmix, then use streetmix street name as the scene sceneTitle but no sceneId; however if opening a 3dstreet scene, then populate both sceneTitle (if exists) and sceneId (if exists)
  • security issue: if I am an evil user and I get the UUID of a "good user" then I can create a .3dstreet.json file that sets the sceneId value to be the good user's valuable scene that will overwrite the contents of good user if evil user convinces them to open the json file and then save to cloud
@kfarr
Copy link
Contributor Author

kfarr commented Sep 8, 2023

here is an example of reproducing the issue

after scene via direct URL (not open modal) while signed in:
image

@kfarr
Copy link
Contributor Author

kfarr commented Sep 12, 2023

the above console screenshot of error was caused by something different, here is resolution of that:
54d64ab

next step for this

  • test -- in editor, when opening scene from url, is ID and name persisted? - yes, this causes separate issue. As a local developer when I encounter a hash load 404 I can save over the contents of the file erasing edits. (Not sure if ticket worthy)
  • in editor, when loading from open modal -- make sure to set sceneId in toolbar state as well as a-frame scene state. Also title!

@kfarr
Copy link
Contributor Author

kfarr commented Sep 12, 2023

closed with #280

@kfarr kfarr closed this as completed Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant