Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metadata component to scene #335

Closed
kfarr opened this issue Sep 3, 2023 · 2 comments
Closed

add metadata component to scene #335

kfarr opened this issue Sep 3, 2023 · 2 comments
Assignees

Comments

@kfarr
Copy link
Collaborator

kfarr commented Sep 3, 2023

this should be the "source of truth" for the title and id of a scene, perhaps other metadata in the future

  • component name metadata
  • 2 property fields: "sceneTitle", "sceneId" both strings
  • this is added to scene by loaders, it is not manually added to a scene

By default the fields are null or empty string

  • Streetmix loader should fill in sceneTitle field using streetmix street name ONLY IF the sceneTitle field is empty
  • 3DStreet JSON loader should overwrite the current scene name when loading a new scene, and load the sceneId from the corresponding field in the document, or set the sceneId to null or empty string if none specified
  • 3DStreet cloud load (from open dialog) should overwrite the current sceneTitle name when loading a new scene as well as the sceneId (this is on 3dstreet-editor repo side, can ignore for this 3dstreet core ticket)

Example of future property fields:

  • createdTimestamp, editedTimestamp, etc.

This will be used by editor for 3DStreet/3dstreet-editor#261 and 3DStreet/3dstreet-editor#275

@kfarr
Copy link
Collaborator Author

kfarr commented Sep 10, 2023

wip #346

@kfarr kfarr mentioned this issue Sep 11, 2023
5 tasks
@kfarr
Copy link
Collaborator Author

kfarr commented Sep 11, 2023

closed by #346

@kfarr kfarr closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants