Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont save JSON value in 'not-street' key in json-utils #344

Closed
Algorush opened this issue Sep 9, 2023 · 3 comments
Closed

dont save JSON value in 'not-street' key in json-utils #344

Algorush opened this issue Sep 9, 2023 · 3 comments
Assignees

Comments

@Algorush
Copy link
Collaborator

Algorush commented Sep 9, 2023

Fix json-utils. Make sure that the function to cancel saving the listed parameters in a JSON file works correctly

@Algorush
Copy link
Collaborator Author

Algorush commented Sep 14, 2023

@kfarr I checked why the JSON property is not being deleted. Because the street component is stored as a string and its properties are not accessed during verification. So the question is: does it make sense to remove the entire street component in JSON file, does it need to save?

@kfarr
Copy link
Collaborator

kfarr commented Sep 19, 2023

you're right, and I'd vote we let it go for now as it's not causing problems and there's plenty of storage space in these json blobs. closing

@kfarr kfarr closed this as completed Sep 19, 2023
@Algorush
Copy link
Collaborator Author

@kfarr I wanted to ask did yet removed street component from the JSON output. Because I have not added it to removeProps in json-utils.js. Or did you do it in one of the PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants