Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash marks #455

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Fix hash marks #455

merged 8 commits into from
Jan 17, 2024

Conversation

kfarr
Copy link
Collaborator

@kfarr kfarr commented Jan 16, 2024

to complete

  • - revert bus segment to previous behavior
  • - fix repeat count for other divider cases

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for 3dstreet-core-builds ready!

Name Link
🔨 Latest commit 33cd92d
🔍 Latest deploy log https://app.netlify.com/sites/3dstreet-core-builds/deploys/65a7283f5580f40008267627
😎 Deploy Preview https://deploy-preview-455--3dstreet-core-builds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfarr kfarr mentioned this pull request Jan 16, 2024
@kfarr
Copy link
Collaborator Author

kfarr commented Jan 16, 2024

Possible implementation methods:

  1. replace the existing divider surface with the new design and superimpose the existing road surface behind it -- easier but adding another texture and naive method will change angle of hash
  2. new logic -- if a variant is "divider" and the ground mixin id has not been changed to elevated grass or sidewalk, then use default drive-lane mixin for segment texture and add repeating hash like other stencils

@kfarr
Copy link
Collaborator Author

kfarr commented Jan 17, 2024

progress using method 1
image

@kfarr
Copy link
Collaborator Author

kfarr commented Jan 17, 2024

before: 80kb (53+27kb) for hatched and hatched normals
now: 42kb just for seamless-lane-with-hatch-half.jpg (saving ~40kb)

@kfarr kfarr marked this pull request as ready for review January 17, 2024 01:00
@kfarr kfarr merged commit 836df72 into main Jan 17, 2024
6 checks passed
@kfarr kfarr deleted the fix-hash-marks branch January 17, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant