-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for new and old metric plan #486
Conversation
✅ Deploy Preview for 3dstreet-core-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
delete old test for calcStreetWidth
@Algorush in Everything else looks ok from a code review perspective, testing will be next |
Also might it be better to remove the calcStreetWidth function from streetmix-utils? Because it is simple now. It is used in two places in the code. And instead calculate the width of the street using reduce of segments array in place:
|
sure! |
This looks good to me. Here was my testing procedure: I temporarily modified line 92 of index.html https://github.com/3DStreet/3dstreet/blob/main/index.html#L92 old new
both seem to work ok with dimensions as expected (per visual inspection) |
#476