Fix issue with string builder removing too much raw sln data on Unix platforms #58
Conversation
…platforms
The implementations incorrectly assume there are two trailing characters to ignore for the newline (i.e. "\r\n"), which is the case for Windows, however this is only a single character on Unix platorms ("\n").
This fix uses Environment.NewLine.Length to determine how many trailing characters to ignore, depending on which platform is being used.
|
Thanks for the PR!
Yes, it's good to have something working before the final solution on
the road.
Let's try to release a new public version immediately for NuGet after merge,
just update the .version file's content up to 2.6.2 in PR;
changelog.txt about fix with your credits if you prefer
|
* FIXED: Fix issue with string builder removing too much raw sln data on Unix platforms.
Related issue: 3F#57
|
Am I missed something on appveyor? o_o https://ci.appveyor.com/project/3Fs/mvssln-fxjnf/builds/47528754 At current time I can't access to my personal pc to debug the reason. Maybe tomorrow. |
|
oh, also, as far as I remember it, PRs should be built automatically by requesting appveyor CI but I don't see anything here anymore. Too many changes out of my sight after a year :( |
|
There's another bug with vssbe API after MSBuild changes for .rsp files in modern environments -_- Fortunately we can suppress it (for windows) temporarily via
(the quotes are in the correct position due to current code hack, hack again)
so much for one little thing ... @teekayarezee Thanks again for your time, it is appreciated! |
The implementations incorrectly assume there are two trailing characters to ignore for the newline (i.e. "\r\n"), which is the case for Windows, however this is only a single character on Unix platorms ("\n").
This results in writing corrupted data to the solution file (for example, manifesting as "EndProjec" appearing in the output sln file when using the WProject write handler).
This fix uses Environment.NewLine.Length to determine how many trailing characters to ignore, depending on which platform is being used.