Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git_commit_id option to config-file parsing #189

Conversation

vanschelven
Copy link

usage.md states "Below the detailed command line options, which can all also be defined using a config file (setup.cfg, tox.ini, pyproject.toml, .django_migration_linter.cfg)"

This was not true for --git-commit-id; it will be after this PR is merged.

@vanschelven
Copy link
Author

I did not check whether other options are similarly affected.

@codecov-commenter
Copy link

Codecov Report

Merging #189 (a8d19ad) into main (7674a51) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   93.40%   93.40%           
=======================================
  Files          77       77           
  Lines        1653     1653           
=======================================
  Hits         1544     1544           
  Misses        109      109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7674a51...a8d19ad. Read the comment docs.

@David-Wobrock
Copy link
Collaborator

Thanks! Let's see if we want to add more options in this PR before merging :)
See #167

@David-Wobrock
Copy link
Collaborator

Superseded by #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants