refactor(KtButtonGroup): Proper TypeScript Types #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianWendelborn
added
type:refactor
priority:3-normal
|
Your Render PR Server URL is https://kotti-pr-493.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4rrjfsobjddd9dd0gk0. |
FlorianWendelborn
force-pushed
the
refactor-kt-button-group
branch
from
5d1b9a4
to
2abc15a
Compare
Isokaeder
approved these changes
Sep 8, 2021
FlorianWendelborn
force-pushed
the
refactor-kt-button-group
branch
from
2abc15a
to
21f6ab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed
shadow, as it was only used internally and the benefit of it is questionable at best.Renamed
.button-groupto.kt-button-group