chore(ci): node-version to latest LTS (18) #680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://kotti-pr-680.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ce0d5npgp3jsllu5a2f0. |
carsoli
added
type:chore
santiagoballadares
previously approved these changes
Nov 25, 2022
carsoli
force-pushed
the
update-ci-to-latest-node
branch
6 times, most recently
from
370b384
to
e1f1ab2
Compare
carsoli
requested review from
FlorianWendelborn
and removed request for
Isokaeder
FlorianWendelborn
requested changes
Nov 25, 2022
FlorianWendelborn
requested changes
Nov 25, 2022
carsoli
force-pushed
the
update-ci-to-latest-node
branch
3 times, most recently
from
e6b333a
to
a256872
Compare
carsoli
force-pushed
the
update-ci-to-latest-node
branch
3 times, most recently
from
fc02980
to
d72dbe1
Compare
| @@ -128,7 +128,7 @@ | |||
| "private": true, | |||
| "repository": "git@github.com:3YOURMIND/kotti", | |||
| "scripts": { | |||
| "build:render.com": "yarn run watch:build-kotti-dependencies && yarn workspace @3yourmind/kotti-ui run build && yarn workspace @3yourmind/documentation run nuxt generate", | |||
There was a problem hiding this comment.
@carsoli Can you explain why setting the webpack hash function wasn’t sufficient for this?
carsoli
force-pushed
the
update-ci-to-latest-node
branch
from
d72dbe1
to
27ac926
Compare
FlorianWendelborn
force-pushed
the
update-ci-to-latest-node
branch
24 times, most recently
from
6910c78
to
d743580
Compare
51 tasks
FlorianWendelborn
force-pushed
the
update-ci-to-latest-node
branch
2 times, most recently
from
0c10d47
to
fbacf96
Compare
|
closing, not needed thanks to supporting node18 on #814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR updates node version for ci and gh-pages to latest LTS (18.12.x) on its creation date (Nov. 25th, 2022).
However:
render deployments are failing with this Error if current LTS (18.12) is used:
The particular sub-dependency that fails according to logs from
masterare webpack and its subdependencies.Given that webpack4 still uses open-ssl < 3.
Until webpack v6, this wouldn't be resolved. Therefore, we upgrade node-version for all CI jobs that use
actions/setup-nodeto be 18, and set node_options to use legacy openssl like here..nvmrcversion overrides render's node-version (which is currentlylts/*(v18).When webpack fixes this in its next major release, we can 1) upgrade 2) no longer need to opt out of using openssl3.