Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Text Class's bugs in shaders branch (the same as #1030) #1031

Merged
merged 7 commits into from May 7, 2020
Merged

Fix Text Class's bugs in shaders branch (the same as #1030) #1031

merged 7 commits into from May 7, 2020

Conversation

TonyCrane
Copy link
Collaborator

Fixed Three bugs of Text Class.
This pull request is the same as #1030
Without this, Text Class wouldn't work in the 'shaders' branch.

@TonyCrane TonyCrane changed the title Fix Text Class's bugs (the same as #1030) Fix Text Class's bugs in shaders branch (the same as #1030) May 5, 2020
@NavpreetDevpuri
Copy link
Contributor

NavpreetDevpuri commented May 6, 2020

i also changed text_mobject.py in #1018
i also update file to newer version but in file changes it shows that i also added lines that you added, but its should show only my changes. does it create any problem or its okay ?

@TonyCrane
Copy link
Collaborator Author

i also changed text_mobject.py in #1018
i also update file to newer version but in file changes it shows that i also added lines that you added, but its should show only my changes. does it create any problem or its okay ?

This pull request is of shaders branch not master. If you want update text_mobject.py you can just pull the newer version from master, because my pull request #1030 has already been merged.

@NavpreetDevpuri
Copy link
Contributor

thanks
understood!

@eulertour eulertour merged commit d83fa90 into 3b1b:shaders May 7, 2020
eulertour pushed a commit to eulertour/manim-3b1b that referenced this pull request Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants