[Feat] - Performance Improvements to `GLDraw.ts`, `GLCartoon.ts`, `GLModel.ts` #662

adithyaakrishna · 2023-03-23T15:28:50Z

Description:

This PR is Related to [Feat] - Performance Improvements For TS Files in src/ #661 - Optimized GLDraw.ts
This PR is Related to [Feat] - Performance Improvements For TS Files in src/ #661 - Optimized GLCartoon.ts
This PR is Related to [Feat] - Performance Improvements For TS Files in src/ #661 - Optimized GLModel.ts

adithyaakrishna · 2023-03-23T16:07:57Z

@dkoes I'm trying to figure out why the CI is failing here, but wasn't able to. Could you please help me with this or suggest what needs to be done?

dkoes · 2023-03-23T16:42:11Z

Is npm test not failing in your local checkout?

adithyaakrishna · 2023-03-23T16:44:59Z

@dkoes Figured it out, it's an issue with .set() functions which I added for Arrays. They are mostly Float32Arrays and I don't think the set() works with them, I will send a fix for that :)

dkoes · 2023-03-23T17:09:15Z

If the goal is more performant code (great goal!), it would be good to setup a performance benchmarking suite before making changes to make sure improvements are happening. For example, recording the render times of the test suite.

adithyaakrishna · 2023-03-23T17:40:40Z

I think the set() methods are working fine, but its something related to TS and Node/NPM

@dkoes The tests are failing on the master branch for me :(

Around 18 tests are failing not sure why and this is the error which I am getting for all of them,

Edit 1: npm run glcheck seems to be working fine and all 266 tests passed with respect to this script

adithyaakrishna · 2023-03-24T05:15:20Z

@dkoes I found the issue to be my system itself, its based on arm architecture and node-canvas does not support prebuilt binaries for this architecture. I will continue to update the codebase based on perf improvements. I have a secondary PC which used intel x86_x64 architecture in which I can run the tests and check where it is breaking down :)

Signed-off-by: Adithya Krishna <adikrish@redhat.com>

dkoes

I am never going to approve this PR. There are too many changes and too many of them would introduce regressions (a few minutes looking through several and I only looked at a small fraction of the changes). I suggest starting over. Only make a change if you can prove it is actually an improvement and provide the proof in the PR. There should not be one single "performance improvement" PR, but separate PRs for each issue addressed. (e.g. use of Math.hypot at all relevant places)

dkoes · 2023-06-13T13:15:17Z

src/GLModel.ts

-        var vertexArray = geoGroup.vertexArray;
-        var colorArray = geoGroup.colorArray;
+        const vertices = [];
+        const colors = [];


What evidence is there this is a good idea? Instead of directly setting values in an already allocated fixed-size array you are using a second, dynamically resizing list.

dkoes · 2023-06-13T13:17:21Z

src/GLModel.ts

                if (l > bestlen) {
                    bestlen = l;
                    bestv = v;
-                    if (bestlen > 0.1) {


You've removed the short circuiting of the loop so now it will run longer. Why do you think this is an improvement?

dkoes · 2023-06-13T13:18:59Z

src/GLDraw.ts

-        // recast dy in terms of new axes - z is the same
+        // Using Math.hypot(dx,dy) instead of Math.sqrt(dx * dx + dy * dy)
+        const dxy = Math.hypot(dx, dy);
+        const { sin: sinA, cos: cosA } = dxy < 0.0001 ? { sin: 0, cos: 1 } : { sin: -dx / dxy, cos: dy / dxy };


Creating an object has more overhead than two simple variables.

dkoes · 2023-06-13T13:24:14Z

src/GLDraw.ts

-        rot[6] = sinA * sinB;
-        rot[7] = -cosA * sinB;
-        rot[8] = cosB;
+        const rot = new Float32Array([cosA, sinA, 0, -sinA * cosB, cosA * cosB, sinB, sinA * sinB, -cosA * sinB, cosB]);


Setting the values individually instead of allocating a list first is more than twice as fast (go ahead and run it through JSBench.Me)

dkoes · 2023-06-13T13:27:17Z

src/GLDraw.ts

                // bottom
-                nvecs.push(this.basisVectors[i].clone().multiplyScalar(radius));
+                nvecs.push(this.basisVectors[i].multiplyScalar(radius));


removing the clone will modify the basisVectors

adithyaakrishna · 2023-06-13T13:34:17Z

@dkoes I completely understand, I will work on creating seperate PRs for the same. There were a couple of changes I had done, but these were without much understanding of the library. I will close this and create seperate ones as you suggested

adithyaakrishna changed the title ~~[Feat] - Performance Improvements~~ [Feat] - Performance Improvements to GLDraw.ts Mar 23, 2023

adithyaakrishna marked this pull request as ready for review March 23, 2023 16:06

adithyaakrishna changed the title ~~[Feat] - Performance Improvements to GLDraw.ts~~ [Feat] - Performance Improvements to GLDraw.ts, GLCartoon.ts, GLModel.ts May 20, 2023

Adithya Krishna added 10 commits June 13, 2023 07:41

Moved piValue to Constants

3488258

Signed-off-by: Adithya Krishna <adikrish@redhat.com>

Fixed Deprecation Warnings

af40b99

Signed-off-by: Adithya Krishna <adikrish@redhat.com>

Optimized GLDraw.ts

4e605fb

Signed-off-by: Adithya Krishna <adikrish@redhat.com>

Optimized GLDraw.ts Arrays

c2958a1

Signed-off-by: Adithya Krishna <adikrish@redhat.com>

Optimized Arrays and Updated Variables

06aa51b

Signed-off-by: Adithya Krishna <adikrish@redhat.com>

Added Export for Constants to Index Files

8c2d100

Signed-off-by: Adithya Krishna <adikrish@redhat.com>

Optimized glcartoon.ts

af9bb3a

Signed-off-by: Adithya Krishna <adikrish@redhat.com>

Optimized GLModel.ts

46a9071

Signed-off-by: Adithya Krishna <adikrish@redhat.com>

Updated Jest Tests

fd35019

Signed-off-by: Adithya Krishna <adikrish@redhat.com>

Added EOL

1c23a8a

Signed-off-by: Adithya Krishna <adikrish@redhat.com>

adithyaakrishna force-pushed the feat/perf-improvements branch from 37b92d1 to 1c23a8a Compare June 13, 2023 07:41

dkoes requested changes Jun 13, 2023

View reviewed changes

adithyaakrishna closed this Jun 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feat] - Performance Improvements to `GLDraw.ts`, `GLCartoon.ts`, `GLModel.ts` #662

[Feat] - Performance Improvements to `GLDraw.ts`, `GLCartoon.ts`, `GLModel.ts` #662

adithyaakrishna commented Mar 23, 2023 •

edited

Loading

adithyaakrishna commented Mar 23, 2023

dkoes commented Mar 23, 2023

adithyaakrishna commented Mar 23, 2023

dkoes commented Mar 23, 2023

adithyaakrishna commented Mar 23, 2023 •

edited

Loading

adithyaakrishna commented Mar 24, 2023

dkoes left a comment •

edited

Loading

dkoes Jun 13, 2023

dkoes Jun 13, 2023

dkoes Jun 13, 2023

dkoes Jun 13, 2023

dkoes Jun 13, 2023

adithyaakrishna commented Jun 13, 2023

[Feat] - Performance Improvements to GLDraw.ts, GLCartoon.ts, GLModel.ts #662

[Feat] - Performance Improvements to GLDraw.ts, GLCartoon.ts, GLModel.ts #662

Conversation

adithyaakrishna commented Mar 23, 2023 • edited Loading

adithyaakrishna commented Mar 23, 2023

dkoes commented Mar 23, 2023

adithyaakrishna commented Mar 23, 2023

dkoes commented Mar 23, 2023

adithyaakrishna commented Mar 23, 2023 • edited Loading

adithyaakrishna commented Mar 24, 2023

dkoes left a comment • edited Loading

Choose a reason for hiding this comment

dkoes Jun 13, 2023

Choose a reason for hiding this comment

dkoes Jun 13, 2023

Choose a reason for hiding this comment

dkoes Jun 13, 2023

Choose a reason for hiding this comment

dkoes Jun 13, 2023

Choose a reason for hiding this comment

dkoes Jun 13, 2023

Choose a reason for hiding this comment

adithyaakrishna commented Jun 13, 2023

[Feat] - Performance Improvements to `GLDraw.ts`, `GLCartoon.ts`, `GLModel.ts` #662

[Feat] - Performance Improvements to `GLDraw.ts`, `GLCartoon.ts`, `GLModel.ts` #662

adithyaakrishna commented Mar 23, 2023 •

edited

Loading

adithyaakrishna commented Mar 23, 2023 •

edited

Loading

dkoes left a comment •

edited

Loading