Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes for node 14 upgrade #2678

Closed
2 tasks
carmenfan opened this issue Jul 7, 2021 · 1 comment
Closed
2 tasks

Small fixes for node 14 upgrade #2678

carmenfan opened this issue Jul 7, 2021 · 1 comment
Assignees
@carmenfan
Labels
config update In Staging Maintenance
Projects
v4.18.0
Milestone
4.17.0

Comments

@carmenfan
Copy link
Member

carmenfan commented Jul 7, 2021 •
edited

Description

  • backend logger is no longer formatted:
    image

  • there's a lot of warnings if you do a fresh yarn install:
    image

Tests

  • model upload should still work as usual
  • check login records are still logging IP correctly

config update

config.logfile.noColors = true to get plain logs.
@carmenfan carmenfan self-assigned this Jul 7, 2021
@carmenfan carmenfan added this to To do in v4.18.0 via automation Jul 7, 2021
@keifgwinn
Copy link
Contributor

ooh, can we use this as an opportunity to fix the logging =D been meaning to raise that for ages

carmenfan added a commit that referenced this issue Jul 7, 2021
@carmenfan
ISSUE #2678 removed fs.extra dependency
b7d7997
carmenfan added a commit that referenced this issue Jul 8, 2021
@carmenfan
ISSUE #2678 centralise UUID generation in utils
2a7bbc0
carmenfan added a commit that referenced this issue Jul 8, 2021
@carmenfan
ISSUE #2678 couple more upgrades
14eec19
carmenfan added a commit that referenced this issue Jul 8, 2021
@carmenfan
ISSUE #2678 linter fix
11351fa
carmenfan added a commit that referenced this issue Jul 8, 2021
@carmenfan
ISSUE #2678 fix uuid lib update
ff5d7e5
carmenfan added a commit that referenced this issue Jul 8, 2021
@carmenfan
ISSUE #2678 format logger
ff6c67a
carmenfan added a commit that referenced this issue Jul 8, 2021
@carmenfan
ISSUE #2678 log user name to request if available
e866674
carmenfan added a commit that referenced this issue Jul 8, 2021
@carmenfan
ISSUE #2678 option to have no colours on the log
ebaeb80
carmenfan added a commit that referenced this issue Jul 8, 2021
@carmenfan
ISSUE #2678 track network latency, reformat the log
453bf22
carmenfan added a commit that referenced this issue Jul 8, 2021
@carmenfan
ISSUE #2678 add network label on all network io logging
3428510
carmenfan added a commit that referenced this issue Jul 8, 2021
@carmenfan
ISSUE #2678 NET instead of NETWORK
8c2a394
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 more log formatting, pass req to genResponseLog on the st…
74bb4ef 
…reaming version
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 mocha now needs a recursive flag
a09b6d2
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 fix user creations
9c9ea6d
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 downgrade socket io - it's not working
53fa5fc
@carmenfan carmenfan mentioned this issue Jul 9, 2021
Closed
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 fix all createUser calls
181075e
@carmenfan carmenfan mentioned this issue Jul 9, 2021
Merged
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 mocha needs to run with --exit; only log if there's trans…
ffd6b23 
…porters
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 remove tag check
c7c0c8c
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 only run meta - struggling to reproduce.
9f2368d
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
Revert "ISSUE #2678 only run meta - struggling to reproduce."
ef79776 
This reverts commit 9f2368d.
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 if no collaborator/issues?
983f5f5
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 try downgrading mocha
eefe677
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 debug logging on metadata endpoint
b950641
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 more debugging
456ec0c
carmenfan added a commit that referenced this issue Jul 9, 2021
@carmenfan
ISSUE #2678 more debugging
0a505b4
carmenfan added a commit that referenced this issue Jul 10, 2021
@carmenfan
ISSUE #2678 more debugging
362fc2f
carmenfan added a commit that referenced this issue Jul 10, 2021
@carmenfan
ISSUE #2678 downgrade nyc
0be7b32
carmenfan added a commit that referenced this issue Jul 10, 2021
@carmenfan
ISSUE #2678 don't run code coverage?
ad7a015
carmenfan added a commit that referenced this issue Jul 10, 2021
@carmenfan
ISSUE #2678 move mocha back to v9
e886ecb
@carmenfan carmenfan mentioned this issue Jul 10, 2021
Closed
carmenfan added a commit that referenced this issue Jul 13, 2021
@carmenfan
Issue 2678 - fixes for nodejs 14 upgrade (#2682)
14a616a 
* ISSUE #2678 removed fs.extra dependency

* Remove unused libraries, replace ip-to-location with geoip-lite

* ISSUE #2678 centralise UUID generation in utils

* ISSUE #2678 couple more upgrades

* ISSUE #2678 linter fix

* ISSUE #2678 fix uuid lib update

* ISSUE #2678 format logger

* ISSUE #2678 log user name to request if available

* ISSUE #2678 option to have no colours on the log

* ISSUE #2678 track network latency, reformat the log

* ISSUE #2678 add network label on all network io logging

* ISSUE #2678 NET instead of NETWORK

* ISSUE #2678 more log formatting, pass req to genResponseLog on the streaming version

* ISSUE #2678 mocha now needs a recursive flag

* ISSUE #2678 fix user creations

* ISSUE #2678 downgrade socket io - it's not working

* ISSUE #2678 fix all createUser calls

* ISSUE #2678 mocha needs to run with --exit; only log if there's transporters

* ISSUE #2678 remove tag check

* ISSUE #2678 only run meta - struggling to reproduce.

* Revert "ISSUE #2678 only run meta - struggling to reproduce."

This reverts commit 9f2368d.

* ISSUE #2678 if no collaborator/issues?

* ISSUE #2678 try downgrading mocha

* ISSUE #2678 debug logging on metadata endpoint

* ISSUE #2678 more debugging

* ISSUE #2678 more debugging

* ISSUE #2678 more debugging

* ISSUE #2678 downgrade nyc

* ISSUE #2678 don't run code coverage?

* ISSUE #2678 move mocha back to v9
@carmenfan carmenfan added this to the 4.17.0 milestone Jul 14, 2021
v4.18.0 automation moved this from To do to Done Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carmenfan carmenfan

Labels
config update In Staging Maintenance
Projects
No open projects
v4.18.0
Done
Milestone
4.17.0
Development

No branches or pull requests
2 participants
@carmenfan @keifgwinn