Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2678 - fixes for nodejs 14 upgrade #2682

Merged
merged 32 commits into from
Jul 13, 2021
Merged

Issue 2678 - fixes for nodejs 14 upgrade #2682

merged 32 commits into from
Jul 13, 2021

Conversation

carmenfan
Copy link
Member

@carmenfan carmenfan commented Jul 9, 2021 •
edited
Loading

This fixes #2678

Description

  • simplified the logging - log is reformatted to be the same as bouncer worker, got rid of all the extra functions that didn't really work
  • make all uuid generation go through the function in utils
  • upgraded/replaced most of the libraries that were throwing out errors. Some had to be left as there's no update. socket io was kept at the same version as it broken (Upgrade socket io #2681 created to deal with this)
  • removed coverall check for now, there seems to be a problem with nyc/istanbul where it errors out on generating coverage information. (revive coverall and apply it on integration tests #2683)
  • new optional config to turn off colourisation on the log

Test cases

  • should work as before
  • logging should no longer look like it's a mess.

@carmenfan
ISSUE #2678 removed fs.extra dependency
b7d7997
@carmenfan
Remove unused libraries, replace ip-to-location with geoip-lite
3c2d949
@carmenfan
ISSUE #2678 centralise UUID generation in utils
2a7bbc0
@carmenfan
ISSUE #2678 couple more upgrades
14eec19
@carmenfan
ISSUE #2678 linter fix
11351fa
@carmenfan
ISSUE #2678 fix uuid lib update
ff5d7e5
@carmenfan
ISSUE #2678 format logger
ff6c67a
@carmenfan
ISSUE #2678 log user name to request if available
e866674
@carmenfan
ISSUE #2678 option to have no colours on the log
ebaeb80
@carmenfan
ISSUE #2678 track network latency, reformat the log
453bf22
@carmenfan
ISSUE #2678 add network label on all network io logging
3428510
@carmenfan
ISSUE #2678 NET instead of NETWORK
8c2a394
@carmenfan
ISSUE #2678 more log formatting, pass req to genResponseLog on the st…
74bb4ef 
…reaming version
@carmenfan
ISSUE #2678 mocha now needs a recursive flag
a09b6d2
@carmenfan
ISSUE #2678 fix user creations
9c9ea6d
@carmenfan
Merge branch 'staging' into ISSUE_2678
0fbd88b
@carmenfan
ISSUE #2678 downgrade socket io - it's not working
53fa5fc
@carmenfan
ISSUE #2678 fix all createUser calls
181075e
@keifgwinn
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carmenfan
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carmenfan carmenfan merged commit 14a616a into staging Jul 13, 2021
@carmenfan carmenfan deleted the ISSUE_2678 branch December 13, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanmont3drepo sanmont3drepo sanmont3drepo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carmenfan @keifgwinn @sanmont3drepo