Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE #4830 - 2d Milestone 1 #4836

Merged
merged 469 commits into from
Sep 12, 2024
Merged

ISSUE #4830 - 2d Milestone 1 #4836

merged 469 commits into from
Sep 12, 2024

Conversation

sanmont3drepo
Copy link
Contributor

@sanmont3drepo sanmont3drepo commented Mar 15, 2024

This fixes #4830

Description

  • Milestone 1 for 2d drawing. More details here

@sanmont3drepo sanmont3drepo changed the title ISSUE #4380 - 2d Milestone 1 ISSUE #4830 - 2d Milestone 1 Mar 15, 2024
@sanmont3drepo sanmont3drepo marked this pull request as draft March 15, 2024 14:56
@sanmont3drepo sanmont3drepo marked this pull request as ready for review April 24, 2024 13:48
@sanmont3drepo sanmont3drepo marked this pull request as draft April 24, 2024 13:55
@sanmont3drepo sanmont3drepo marked this pull request as ready for review May 8, 2024 14:42
@sanmont3drepo sanmont3drepo marked this pull request as draft May 8, 2024 14:42
carmenfan and others added 21 commits September 6, 2024 23:43
Issue 5064 - Calibration endpoints
ISSUE #5130 - Milestone 1: Fixed format of drawing status in drawings list
Issue 5126 - upload drawings fixes
Issue 5108 - Processing PDF
Issue #5127 - Milestone 1 realtime events fixes
@carmenfan carmenfan self-requested a review September 11, 2024 15:07
carmenfan
carmenfan previously approved these changes Sep 12, 2024
Copy link
Member

@carmenfan carmenfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine just a small tooltip that needs fixing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Tooltip doesn't give correct information on drawings (it expands/collapse the revision list, it doesn't launch the drawing)

@carmenfan carmenfan merged commit aa108e5 into staging Sep 12, 2024
11 of 12 checks passed
@carmenfan carmenfan deleted the ISSUE_4830 branch September 12, 2024 14:17
@carmenfan carmenfan removed their assignment Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants