Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash striping too dense #24

Closed
kfarr opened this issue Apr 24, 2020 · 8 comments
Closed

hash striping too dense #24

kfarr opened this issue Apr 24, 2020 · 8 comments
Assignees
Labels

Comments

@kfarr
Copy link
Collaborator

kfarr commented Apr 24, 2020

the hash striping is too dense and does not match the other roadway striping from north america / california

@kfarr kfarr added the bug label Apr 24, 2020
@kfarr
Copy link
Collaborator Author

kfarr commented Jan 15, 2024

@kfarr
Copy link
Collaborator Author

kfarr commented Jan 15, 2024

The texture is kept here:
https://github.com/3DStreet/3dstreet-assets-dist/blob/main/materials/hatchedhd_Base_Color.jpg

Other road markings are kept here:
https://github.com/3DStreet/3dstreet-assets-dist/blob/main/materials/lane-markings-atlas_1024.png

And here:
https://github.com/3DStreet/3dstreet-assets-dist/blob/main/materials/stencils-atlas_2048.png

There could be space in stencils atlas on the right center side to include a repeatable chevron shape (like 2 or 3 "V" characters on top of each other). The application can use either the entire width with the "V" or just the left or right sides with repeating hashes oriented left or right as needed for the street segment.

Example WIP:
image

@kfarr kfarr self-assigned this Jan 16, 2024
@kfarr
Copy link
Collaborator Author

kfarr commented Jan 16, 2024

updated pngs, could use additional compression:
1024:
stencils-atlas_1024
2048:
stencils-atlas_2048

kfarr added a commit to 3DStreet/3dstreet-assets-dist that referenced this issue Jan 16, 2024
@kfarr
Copy link
Collaborator Author

kfarr commented Jan 16, 2024

progress
image

hijacking bus lane for this demo

@kfarr
Copy link
Collaborator Author

kfarr commented Jan 16, 2024

#455

@kfarr
Copy link
Collaborator Author

kfarr commented Jan 17, 2024

this fix caused a regression on existing scenes, the divider segment appears as a white box with no texture

Also old scenes cannot be remixed and saved, there is an error.

I guess it's because of "hatched-base" and "hatched-normal" not available. So I have attempted to add those back to see if it fixes the bug. If not we'll have to revert back to pre dist

@kfarr
Copy link
Collaborator Author

kfarr commented Jan 18, 2024

resolved but caused regression, more info here: #457

@kfarr kfarr closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant