You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suggest adding a check to aframe-streetmix-parser.js: if the segment type selected in streemix.net is not supported, don't try to load it or load the sidewalk segment instead or use the neighboring segment type? Which option is better, @kfarr ?
Since an incorrectly loaded segment can affect other functions. For example, now in this scene (https://3dstreet.app/#https://streetmix.net/kfarr/3/example-street) 3DStreet does not have support for the "drainage-channel" segment and this leads to an error:
Because of this, the boundingBox of this segment element cannot be calculated. Which leads to a problem with other functions: #449 (comment)
The text was updated successfully, but these errors were encountered:
I suggest adding a check to
![image](https://private-user-images.githubusercontent.com/32197767/301352333-3e5ec61c-0f99-481c-a2f0-8b615a2382be.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwMDQ2NDEsIm5iZiI6MTcyNDAwNDM0MSwicGF0aCI6Ii8zMjE5Nzc2Ny8zMDEzNTIzMzMtM2U1ZWM2MWMtMGY5OS00ODFjLWEyZjAtOGI2MTVhMjM4MmJlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDE4MDU0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJmNjkxZDliMzk2MjEwNGZlMzQ1NWE1NjJmN2VmZTljM2Q2YTQ3OWUxODA1ZjkzYjE5YWM0YWIyZjdkNWE4NjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-v6GIU6KZy0hAtZOsZwELbGiOIAiNix8-7t1tTEV1-w)
aframe-streetmix-parser.js
: if the segment type selected instreemix.net
is not supported, don't try to load it or load the sidewalk segment instead or use the neighboring segment type? Which option is better, @kfarr ?Since an incorrectly loaded segment can affect other functions. For example, now in this scene (https://3dstreet.app/#https://streetmix.net/kfarr/3/example-street) 3DStreet does not have support for the "drainage-channel" segment and this leads to an error:
Because of this, the
boundingBox
of this segment element cannot be calculated. Which leads to a problem with other functions: #449 (comment)The text was updated successfully, but these errors were encountered: