Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't load unsupported segment type #464

Closed
Algorush opened this issue Jan 28, 2024 · 1 comment
Closed

don't load unsupported segment type #464

Algorush opened this issue Jan 28, 2024 · 1 comment
Assignees

Comments

@Algorush
Copy link
Collaborator

Algorush commented Jan 28, 2024

I suggest adding a check to aframe-streetmix-parser.js: if the segment type selected in streemix.net is not supported, don't try to load it or load the sidewalk segment instead or use the neighboring segment type? Which option is better, @kfarr ?
Since an incorrectly loaded segment can affect other functions. For example, now in this scene (https://3dstreet.app/#https://streetmix.net/kfarr/3/example-street) 3DStreet does not have support for the "drainage-channel" segment and this leads to an error:
image
Because of this, the boundingBox of this segment element cannot be calculated. Which leads to a problem with other functions: #449 (comment)

@kfarr
Copy link
Collaborator

kfarr commented Mar 7, 2024

closed by #495

@kfarr kfarr closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants