Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: cannot open streetmix url with unsupported segment variants #488

Closed
kfarr opened this issue Mar 1, 2024 · 2 comments
Closed

issue: cannot open streetmix url with unsupported segment variants #488

kfarr opened this issue Mar 1, 2024 · 2 comments
Assignees

Comments

@kfarr
Copy link
Collaborator

kfarr commented Mar 1, 2024

Uncaught TypeError: Cannot read properties of undefined (reading 'length')

Error:
https://3dstreet.app/#https://streetmix.net/kfarr/129/error-proposed-owens-st

Not an error:
https://3dstreet.app/#https://streetmix.net/kfarr/130/proposed-owens-st

The issue seems to be related to drive lane variants that are not supported.

Instead, unsupported variants should be handled gracefully -- they should do best effort to render the scene

In best case there is a nice error message for user in yellow warning notification that says "Street imported from Streetmix but some segment variants are not supported." or at least a console log warning for debugging purposes

@kfarr kfarr changed the title cannot open streetmix url issue: cannot open streetmix url with unsupported segment variants Mar 1, 2024
@Algorush
Copy link
Collaborator

Algorush commented Mar 1, 2024

I mentioned about similar issue:#464
I think it would be helpfull to have a list with supported segment types and variants also. To avoid such cases with variant support. Because now unsupported variants are much more difficult to track, since they are each processed within their own function.
I founded that already created streetmix schema for supported segments and variants when was working with text-to-street bot. I'll take it from there.
...It turned out that not all variants are in this Schema. I'm adding the rest

@kfarr
Copy link
Collaborator Author

kfarr commented Mar 7, 2024

closed by #495

@kfarr kfarr closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants