Remove unchecked use of local storage again #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you access localstorage outside of a try catch as was done with versions > 0.0.3, webpacked bundles using this module will crash in a private browser with 3rd party cookies disabled
|
@3rd-Eden could we consider taking in this PR? I saw there was a similar one from earlier this year that hasn't been taken. I thought that a revert might be more acceptable than adding new code. This package gets included in many projects, including the winston logger package, which I'm using right now. Any bundle that includes this package will throw an uncaught exception and crash in an incognito chrome tab with 3rd party cookies disabled. I can fix this for my case by specifying 0.0.3 of this package in package.json, but I think it would be preferable to make sure that the default/latest version did not have this bug. |
|
Fixed in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing
window.localStorageoutside of a try catch block causes an exception in private browser sessions with 3rd party cookies disabled. We need to revert the change made for version 0.0.4.