Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flush_all as an alias of flush #24

Merged
merged 2 commits into from
Jan 16, 2012
Merged

Conversation

ctavan
Copy link
Contributor

@ctavan ctavan commented Jan 16, 2012

Intuitively I was expecting a method named flush_all since all other memcached protocol commands have their corresponding methods that are named the same way.

Maybe you want to add that method? Alternatively documentation in the readme could help to make things clear.

@3rd-Eden
Copy link
Owner

I'm fine with adding an alias to it, but I think it should be camelCase instead.

@ctavan
Copy link
Contributor Author

ctavan commented Jan 16, 2012

Ok, flushAll() was my second try before looking into the source, after flush_all() failed. So it's maybe more javascript-ish to stick to that camelCase convention. I'm also fine with that.

3rd-Eden added a commit that referenced this pull request Jan 16, 2012
Add flush_all as an alias of flush
@3rd-Eden 3rd-Eden merged commit 0dcbaed into 3rd-Eden:master Jan 16, 2012
@3rd-Eden
Copy link
Owner

Thanks a lot, pushed it to master and added a few other aliases as well.

@ctavan
Copy link
Contributor Author

ctavan commented Jan 16, 2012

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants