fix: parse markdown buffer with markdown parser and get inlines as children #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes interactions with other plugins by not accidentally attaching a wrong parser to markdown buffers (that would get re-used by other plugins when they require the parser).
It should also safeguard against future bugs, because previously we would attach the "markdown_inline" parser directly to the buffer, which would also try to parse all the parts that are not plain markdown (like yaml headers, html and code chunks) as inline markdown.
This does change the behavior slightly, but I'd say makes it more expected. Previously, because the whole buffer would be treated as if it where only "markdown_inline", it would also detect images with the markdown syntax in parts that are not markdown, so this is no longer happening. e.g. if you had a code chunk with a comment that contained some markdown image syntax.